third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc - Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)

Patch Set: spelling. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

index f7ef2e236c9daf7dfb89efc16267fb26051ef9a9..91f6f53a23e5e00bccdcb134ac9c48f90535882e 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

@@ -83,7 +83,7 @@ NGPhysicalFragment* NGFragmentBuilder::ToFragment() {

}

return new NGPhysicalFragment(physical_size,

overflow_.ConvertToPhysical(writing_mode_),

- children, margin_strut_);

+ children, margin_strut_, writing_mode_);

}

} // namespace blink