third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h - Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_fragment_base.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h

index de9b9430c81df2629e5c949774676554d2321c48..b47d5d40230d9fb3708626717fa9781adce7d5a4 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h

@@ -83,6 +83,10 @@ class CORE_EXPORT NGPhysicalConstraintSpace final

unsigned width_direction_fragmentation_type_ : 2;

unsigned height_direction_fragmentation_type_ : 2;

+ // Whether the current constraint space is for the newly established

+ // formatting Context

+ unsigned is_new_fc_ : 1;

HeapVector<Member<const NGExclusion>> exclusions_;

};