Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)
Patch Set: address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
index 6454993fd742a33e55cd718abf06a4e0ced54212..131dbb918730e85ec9d65421cd3e883720c14304 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h
@@ -87,7 +87,7 @@ class CORE_EXPORT NGConstraintSpace final
// Whether the current constraint space is for the newly established
// Formatting Context.
- bool IsNewFormattingContext() const { return is_new_fc_; }
+ bool IsNewFormattingContext() const;
// Whether exceeding the containerSize triggers the presence of a scrollbar
// for the indicated direction.
@@ -123,9 +123,7 @@ class CORE_EXPORT NGConstraintSpace final
void SetOverflowTriggersScrollbar(bool inlineTriggers, bool blockTriggers);
void SetFixedSize(bool inlineFixed, bool blockFixed);
void SetFragmentationType(NGFragmentationType);
- // TODO(layout-ng): Add m_isNewFc flag to ComputedStyle and use it instead of
- // the function below.
- void SetIsNewFormattingContext(bool is_new_fc) { is_new_fc_ = is_new_fc; }
+ void SetIsNewFormattingContext(bool is_new_fc);
String ToString() const;
@@ -135,9 +133,6 @@ class CORE_EXPORT NGConstraintSpace final
NGLogicalSize size_;
unsigned writing_mode_ : 3;
unsigned direction_ : 1;
- // Whether the current constraint space is for the newly established
- // formatting Context
- bool is_new_fc_ : 1;
};
inline std::ostream& operator<<(std::ostream& stream,
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_box.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698