third_party/WebKit/Source/core/layout/ng/ng_fragment.cc - Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment.cc

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)

Patch Set: spelling. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "core/layout/ng/ng_fragment.h"	5 #include "core/layout/ng/ng_fragment.h"

6	6

7 namespace blink {} // namespace blink	7 #include "core/layout/ng/ng_physical_fragment.h"

	8

	9 namespace blink {

	10

	11 NGMarginStrut NGFragment::MarginStrut() const {

	12 return writing_mode_ ==
	Gleb Lanbin 2016/10/13 23:59:51 it's better to use IF instead of a long ternary op it's better to use IF instead of a long ternary operator here.
	13 toNGPhysicalFragment(physical_fragment_)

	14 ->MarginStrutWritingMode()

	15 ? toNGPhysicalFragment(physical_fragment_)->MarginStrut()
	Gleb Lanbin 2016/10/13 23:59:51 toNGPhysicalFragment(physical_fragment_)->MarginSt toNGPhysicalFragment(physical_fragment_)->MarginStrut() is a bit wordy way to access MarginStrut, should we keep it in the base instead ?
	16 : NGMarginStrut();

	17 }

	18

	19 } // namespace blink

OLD	NEW