Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 24171003: cleanup XML_Parser after reading android config files. (Closed)

Created:
7 years, 3 months ago by djsollen
Modified:
7 years, 3 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

cleanup XML_Parser after reading android config files. This CL is based on one submitted for AOSP review... Fix memory leak in parseConfigFile() Need to call XML_ParserFree() on parsers created by XML_ParserCreate() Signed-off-by: Carton He <carton.he@marvell.com>; https://android-review.googlesource.com/#/c/65690/1 R=mtklein@google.com Committed: https://code.google.com/p/skia/source/detail?r=11357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ports/SkFontConfigParser_android.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
djsollen
7 years, 3 months ago (2013-09-18 13:12:07 UTC) #1
mtklein
On 2013/09/18 13:12:07, djsollen wrote: lgtm
7 years, 3 months ago (2013-09-18 13:14:17 UTC) #2
djsollen
7 years, 3 months ago (2013-09-18 18:59:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r11357 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698