Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2417093003:
[async await] Fix debug async task event (Closed)
Description[async await] Fix debug async task event
If the catch prediction machinery in the middle of some async op, we
shouldn't send invalid events to the debugger.
Instead of sending events with an undefined id, we don't send them at
all.
Committed: https://crrev.com/b122da39d06186f9aae7476422e780ddb5db38f7
Cr-Commit-Position: refs/heads/master@{#40327}
Patch Set 1 #
Total comments: 2
Patch Set 2 : fmt #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [async await] Fix async task event If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. ========== to ========== [async await] Fix async task event If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. ==========
gsathya@chromium.org changed reviewers: + adamk@chromium.org
Description was changed from ========== [async await] Fix async task event If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. ========== to ========== [async await] Fix debug async task event If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. ==========
On 2016/10/13 22:49:24, gsathya wrote: Note -- For the other cases, we always generate a new id, so we don't have to worry about sending invalid ids. Also, the catch prediction code has appropriate checks to handle the mismatch in the pushed and popped promises.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2417093003/diff/1/src/js/async-await.js File src/js/async-await.js (right): https://codereview.chromium.org/2417093003/diff/1/src/js/async-await.js#newco... src/js/async-await.js:165: %DebugAsyncTaskEvent({ Indentation looks off here (should be two spaces).
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2417093003/diff/1/src/js/async-await.js File src/js/async-await.js (right): https://codereview.chromium.org/2417093003/diff/1/src/js/async-await.js#newco... src/js/async-await.js:165: %DebugAsyncTaskEvent({ On 2016/10/14 20:31:12, adamk wrote: > Indentation looks off here (should be two spaces). Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gsathya@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org Link to the patchset: https://codereview.chromium.org/2417093003/#ps20001 (title: "fmt")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [async await] Fix debug async task event If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. ========== to ========== [async await] Fix debug async task event If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [async await] Fix debug async task event If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. ========== to ========== [async await] Fix debug async task event If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. Committed: https://crrev.com/b122da39d06186f9aae7476422e780ddb5db38f7 Cr-Commit-Position: refs/heads/master@{#40327} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b122da39d06186f9aae7476422e780ddb5db38f7 Cr-Commit-Position: refs/heads/master@{#40327} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
