DevTools: introduce WI.UISourceCode.requestMetadata()

DevTools: introduce WI.UISourceCode.requestMetadata()

Metadata (modification time + contentSize) is needed for the
automapping to do its job.

This patch introduces UISourceCode.requestMetadata() method
and implements it for FileSystem UISourceCodes.

The implementation for the network UISourceCodes
will be landed separately.

BUG=none
R=dgozman, pfeldman

Committed: https://crrev.com/b41017d0fac5dc4fe71926fe1e27773b6677c407
Cr-Commit-Position: refs/heads/master@{#425262}

[lushnikov, 2016-10-13 20:45:32]

Description was changed from

==========
DevTools: introduce WI.UISourceCode.requestMetadata() method

Metadata (lastModified timestamp + contentSize) is needed for the
Automapping to do its dirty business.

In case of file system UISourceCodes, metadata comes from the
DOMFileSystem.

In case of network UISourceCodes, metadata comes from the underlaying
Resource.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce WI.UISourceCode.requestMetadata() method

Metadata (lastModified timestamp + contentSize) is needed for the
Automapping to do its dirty business.

In case of file system UISourceCodes, metadata comes from the
DOMFileSystem.

In case of network UISourceCodes, metadata comes from the underlaying
Resource.

BUG=none
R=dgozman, pfeldman
==========

[lushnikov, 2016-10-13 20:45:33]

lushnikov@chromium.org changed reviewers:
- dgozman@chromium.org, pfeldman@chromium.org

[lushnikov, 2016-10-14 01:32:05]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[lushnikov, 2016-10-14 01:32:06]

please, take a look

[lushnikov, 2016-10-14 01:32:11]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 01:32:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-10-14 01:32:53]

Description was changed from

==========
DevTools: introduce WI.UISourceCode.requestMetadata() method

Metadata (lastModified timestamp + contentSize) is needed for the
Automapping to do its dirty business.

In case of file system UISourceCodes, metadata comes from the
DOMFileSystem.

In case of network UISourceCodes, metadata comes from the underlaying
Resource.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce WI.UISourceCode.requestMetadata() method

Metadata (modification time + contentSize) is needed for the
automapping to do its job.

In case of file system UISourceCodes, metadata comes from the
DOMFileSystem.

BUG=none
R=dgozman, pfeldman
==========

[lushnikov, 2016-10-14 02:26:46]

Description was changed from

==========
DevTools: introduce WI.UISourceCode.requestMetadata() method

Metadata (modification time + contentSize) is needed for the
automapping to do its job.

In case of file system UISourceCodes, metadata comes from the
DOMFileSystem.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce WI.UISourceCode.requestMetadata()

Metadata (modification time + contentSize) is needed for the
automapping to do its job.

This patch introduces UISourceCode.requestMetadata() method
and implements it for FileSystem UISourceCodes.

The implementation for the network UISourceCodes
will be landed separately.

BUG=none
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-10-14 02:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 02:38:41]

Dry run: Exceeded global retry quota

[dgozman, 2016-10-14 03:35:26]

lgtm

https://codereview.chromium.org/2417083002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js
(right):

https://codereview.chromium.org/2417083002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js:241:
.then(onMetadata);
nit: move to the previous line

[lushnikov, 2016-10-14 05:45:32]

thanks, all done

https://codereview.chromium.org/2417083002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js
(right):

https://codereview.chromium.org/2417083002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js:241:
.then(onMetadata);
On 2016/10/14 03:35:26, dgozman wrote:
> nit: move to the previous line

Done.

[lushnikov, 2016-10-14 05:45:36]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-10-14 05:45:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2417083002/#ps60001
(title: "normalize test + address nit")

[commit-bot: I haz the power, 2016-10-14 05:45:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 06:47:43]

Description was changed from

==========
DevTools: introduce WI.UISourceCode.requestMetadata()

Metadata (modification time + contentSize) is needed for the
automapping to do its job.

This patch introduces UISourceCode.requestMetadata() method
and implements it for FileSystem UISourceCodes.

The implementation for the network UISourceCodes
will be landed separately.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce WI.UISourceCode.requestMetadata()

Metadata (modification time + contentSize) is needed for the
automapping to do its job.

This patch introduces UISourceCode.requestMetadata() method
and implements it for FileSystem UISourceCodes.

The implementation for the network UISourceCodes
will be landed separately.

BUG=none
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-10-14 06:47:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-14 06:49:09]

Description was changed from

==========
DevTools: introduce WI.UISourceCode.requestMetadata()

Metadata (modification time + contentSize) is needed for the
automapping to do its job.

This patch introduces UISourceCode.requestMetadata() method
and implements it for FileSystem UISourceCodes.

The implementation for the network UISourceCodes
will be landed separately.

BUG=none
R=dgozman, pfeldman
==========

to

==========
DevTools: introduce WI.UISourceCode.requestMetadata()

Metadata (modification time + contentSize) is needed for the
automapping to do its job.

This patch introduces UISourceCode.requestMetadata() method
and implements it for FileSystem UISourceCodes.

The implementation for the network UISourceCodes
will be landed separately.

BUG=none
R=dgozman, pfeldman

Committed: https://crrev.com/b41017d0fac5dc4fe71926fe1e27773b6677c407
Cr-Commit-Position: refs/heads/master@{#425262}
==========

[commit-bot: I haz the power, 2016-10-14 06:49:11]

Patchset 4 (id:??) landed as
https://crrev.com/b41017d0fac5dc4fe71926fe1e27773b6677c407
Cr-Commit-Position: refs/heads/master@{#425262}