Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: pkg/front_end/lib/source_span.dart

Issue 2417043003: Initial API for the Dart front_end package. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 /// Defines the API for the front end to communicate information about source
6 /// code locations to clients.
7 library front_end.source_location;
Brian Wilkerson 2016/10/13 23:37:02 If we're going to model source information differe
Paul Berry 2016/10/14 00:09:36 I don't know. I will investigate that package.
8
9 /// A location in an input source file, possibly spanning several characters.
10 class SourceSpan {
Siggi Cherem (dart-lang) 2016/10/13 23:22:16 it would be great if we could use SourceSpan from
Paul Berry 2016/10/14 00:09:36 Acknowledged. I will investigate that package.
11 /// The Uri of the source file.
12 Uri get sourceUri;
Brian Wilkerson 2016/10/13 23:37:02 I would suggest 'uri'; I think it's clear that thi
Paul Berry 2016/10/14 00:09:36 Fair enough.
13
14 /// The character offset from the beginning of the source file to the start of
15 /// the span.
16 int get offset;
17
18 /// The number of characters encompassed by the span.
19 int get length;
20
21 /// The line number of the start of the span (one-based).
22 int get startLine;
23
24 /// The character position of the start of the span (zero-based).
25 int get startChar;
Brian Wilkerson 2016/10/13 23:37:02 I would suggest 'startColumn' (and 'endColumn') as
Paul Berry 2016/10/14 00:09:36 Sounds reasonable.
26
27 /// The line number of the end of the span (one-based).
28 int get endLine;
29
30 /// The character position of the end of the span (zero-based).
31 int get endChar;
32 }
OLDNEW
« pkg/front_end/lib/compiler_api.dart ('K') | « pkg/front_end/lib/compiler_api.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698