Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2417043002: Move device/core files to device/base directory. (Closed)

Created:
4 years, 2 months ago by darktears
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), davemoore+watch_chromium.org, devtools-reviews_chromium.org, extensions-reviews_chromium.org, markusheintz_, msramek+watch_chromium.org, oshima+watch_chromium.org, pfeldman, qsr+mojo_chromium.org, raymes+watch_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move device/core files to device/base directory. The files are being moved from device/core to device/base to follow the de-facto standards in other directories (such as net/, ui/, cc/, ...) I also fixed the FOR_EACH_OBSERVER calls which are now prohibited (git cl upload was complaining). BUG= Committed: https://crrev.com/2fe63eaa21f1aaa7ff54f5358182c14695fe0fde Cr-Commit-Position: refs/heads/master@{#425173}

Patch Set 1 #

Patch Set 2 : Fix ChromeOS build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -940 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_device_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/printer_detector/printer_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/usb/android_usb_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/device_permissions_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/usb_chooser_dialog_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/usb_internals/usb_internals_page_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_chooser_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/web_usb_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/web_usb_detector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A + device/base/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
A device/base/device_base_export.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + device/base/device_client.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + device/base/device_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A + device/base/device_info_query_win.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + device/base/device_info_query_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + device/base/device_monitor_linux.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + device/base/device_monitor_linux.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download
A + device/base/device_monitor_win.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + device/base/device_monitor_win.cc View 6 chunks +11 lines, -15 lines 0 comments Download
A + device/base/mock_device_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + device/base/mock_device_client.cc View 1 chunk +1 line, -1 line 0 comments Download
D device/core/BUILD.gn View 1 chunk +0 lines, -54 lines 0 comments Download
D device/core/device_client.h View 1 chunk +0 lines, -42 lines 0 comments Download
D device/core/device_client.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D device/core/device_core_export.h View 1 chunk +0 lines, -28 lines 0 comments Download
D device/core/device_info_query_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D device/core/device_info_query_win.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D device/core/device_monitor_linux.h View 1 chunk +0 lines, -74 lines 0 comments Download
D device/core/device_monitor_linux.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D device/core/device_monitor_win.h View 1 chunk +0 lines, -50 lines 0 comments Download
D device/core/device_monitor_win.cc View 1 chunk +0 lines, -210 lines 0 comments Download
D device/core/mock_device_client.h View 1 chunk +0 lines, -39 lines 0 comments Download
D device/core/mock_device_client.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M device/hid/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/hid_service_win.h View 1 chunk +1 line, -1 line 0 comments Download
M device/hid/input_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_io_handler_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/test/test_device_client.h View 1 chunk +1 line, -1 line 0 comments Download
M device/test/usb_test_gadget_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/mojo/device_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/mojo/device_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/usb_service_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/device_permissions_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/device_permissions_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/hid/hid_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/hid/hid_device_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/usb/usb_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/usb/usb_guid_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_device_client.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
darktears
@reillyg : please review the device/ and extensions/ part. @jochen : I need a rs ...
4 years, 2 months ago (2016-10-13 20:38:27 UTC) #8
Reilly Grant (use Gerrit)
lgtm
4 years, 2 months ago (2016-10-13 20:54:26 UTC) #9
Lei Zhang
chrome/ lgtm
4 years, 2 months ago (2016-10-13 21:34:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417043002/20001
4 years, 2 months ago (2016-10-13 21:36:14 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 21:43:12 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 21:45:11 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fe63eaa21f1aaa7ff54f5358182c14695fe0fde
Cr-Commit-Position: refs/heads/master@{#425173}

Powered by Google App Engine
This is Rietveld 408576698