Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2416973003: Reapply "Use a single file for app snapshots." (Closed)

Created:
4 years, 2 months ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply "Use a single file for app snapshots." - Don't read script to check for an app snapshot if it is a pipe. Fixes loading source from a pipe. - Fix windows and fushsia builds. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/3d00ecdc8f8e4da4a0b3f48103a7e0d7845136a7

Patch Set 1 #

Patch Set 2 : sync #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -290 lines) Patch
M runtime/bin/dartutils.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/bin/extensions_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/extensions_fuchsia.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/extensions_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/extensions_macos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/extensions_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/file.h View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/bin/file_android.cc View 1 chunk +15 lines, -9 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file_linux.cc View 1 chunk +15 lines, -8 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 chunk +15 lines, -8 lines 0 comments Download
M runtime/bin/file_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/gen_snapshot.cc View 4 chunks +21 lines, -29 lines 0 comments Download
M runtime/bin/main.cc View 10 chunks +213 lines, -162 lines 1 comment Download
M runtime/include/dart_api.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 4 chunks +4 lines, -24 lines 0 comments Download
M runtime/vm/snapshot.h View 3 chunks +12 lines, -3 lines 0 comments Download
M runtime/vm/snapshot.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 3 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rmacnak
4 years, 2 months ago (2016-10-13 23:51:18 UTC) #2
siva
lgtm
4 years, 2 months ago (2016-10-14 00:10:24 UTC) #3
rmacnak
Committed patchset #2 (id:20001) manually as 3d00ecdc8f8e4da4a0b3f48103a7e0d7845136a7 (presubmit successful).
4 years, 2 months ago (2016-10-14 16:58:00 UTC) #5
zra
4 years, 2 months ago (2016-10-18 16:16:46 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2416973003/diff/20001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/2416973003/diff/20001/runtime/bin/main.cc#new...
runtime/bin/main.cc:1313: if (File::GetType(script_name, true) != File::kIsFile)
{
On Windows, this calls Dart_ScopeAllocate, which fails as various thread locals
haven't been initialized, yet, causing all tests to fail.

Powered by Google App Engine
This is Rietveld 408576698