Issue 2416963009: Minor cleanup: use handle when setting instructions in code object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2416963009: Minor cleanup: use handle when setting instructions in code object. (Closed)

Created:
4 years, 2 months ago by regis

Modified:
4 years, 2 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	runtime/vm/object.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/precompiler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

Some methods of Instructions also take RawInstructions* as arguments, but since they are used in ...

4 years, 2 months ago (2016-10-14 22:33:53 UTC) #2

regis

4 years, 2 months ago (2016-10-14 23:07:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0ac91fab5c971ab2cf710debd2ec506d93b9de07 (presubmit successful).