Range object should check root node identify instead of inActiveDocument().

third_party/WebKit/Source/core/dom/Range.cpp

Index: third_party/WebKit/Source/core/dom/Range.cpp
diff --git a/third_party/WebKit/Source/core/dom/Range.cpp b/third_party/WebKit/Source/core/dom/Range.cpp
index 6021e30bf9b6297558fb3eae9767502956ad1880..db0501312c2373424e53eacce49ad180833209c9 100644
--- a/third_party/WebKit/Source/core/dom/Range.cpp
+++ b/third_party/WebKit/Source/core/dom/Range.cpp
@@ -247,6 +247,17 @@ bool Range::isNodeFullyContained(Node& node) const {
                                                // points.
 }
 
+bool Range::hasSameRoot(const Node& node) const {
+  if (node.document() != m_ownerDocument)
+    return false;
+  // commonAncestorContainer() is O(depth). We should avoid to call it in common
+  // cases.
+  if (node.isConnected() && m_start.container()->isConnected() &&

[yosin_UTC9, 2016/10/17 04:14:30]

Q: Is it better to use isInTreeScope() == isConnected or isInShadowTree?

[tkent, 2016/10/17 04:48:03]

Yeah, that's a good idea.  It improves the coverage of this fast-path.  Done in
Patch Set 2.

+      &node.treeScope() == &m_start.container()->treeScope())
+    return true;
+  return commonAncestorContainer(m_start.container(), &node);

[yosin_UTC9, 2016/10/17 04:14:30]

nit: Is
m_start.container()->treeScope().commonAncestorTreeScope(node.treeScope())
faster than commonAncestorContainer(Node*, Node*)?

[tkent, 2016/10/17 04:48:03]

The comparison doesn't make sense because we can't use commonAncestorTreeScope()
here.

+}
+
 bool Range::isPointInRange(Node* refNode,
                            int offset,
                            ExceptionState& exceptionState) const {
@@ -256,10 +267,8 @@ bool Range::isPointInRange(Node* refNode,
     exceptionState.throwTypeError("The node provided is null.");
     return false;
   }
-
-  if (!refNode->inActiveDocument() || refNode->document() != m_ownerDocument) {
+  if (!hasSameRoot(*refNode))
     return false;
-  }
 
   checkNodeWOffset(refNode, offset, exceptionState);
   if (exceptionState.hadException())
@@ -281,16 +290,10 @@ short Range::comparePoint(Node* refNode,
   // refNode node and an offset within the node is before, same as, or after the
   // range respectively.
 
-  if (!refNode->inActiveDocument()) {
-    exceptionState.throwDOMException(
-        WrongDocumentError, "The node provided is not in an active document.");
-    return 0;
-  }
-
-  if (refNode->document() != m_ownerDocument) {
+  if (!hasSameRoot(*refNode)) {
     exceptionState.throwDOMException(
         WrongDocumentError,
-        "The node provided is not in this Range's Document.");
+        "The node provided and the Range are not in the same tree.");
     return 0;
   }
 
@@ -405,28 +408,16 @@ void Range::deleteContents(ExceptionState& exceptionState) {
   }
 }
 
-static bool nodeValidForIntersects(Node* refNode,
-                                   Document* expectedDocument,
-                                   ExceptionState& exceptionState) {
+bool Range::intersectsNode(Node* refNode, ExceptionState& exceptionState) {
+  // http://developer.mozilla.org/en/docs/DOM:range.intersectsNode
+  // Returns a bool if the node intersects the range.
   if (!refNode) {
     // FIXME: Generated bindings code never calls with null, and neither should
     // other callers!
     exceptionState.throwTypeError("The node provided is null.");
     return false;
   }
-
-  if (!refNode->inActiveDocument() || refNode->document() != expectedDocument) {
-    // Firefox doesn't throw an exception for these cases; it returns false.
-    return false;
-  }
-
-  return true;
-}
-
-bool Range::intersectsNode(Node* refNode, ExceptionState& exceptionState) {
-  // http://developer.mozilla.org/en/docs/DOM:range.intersectsNode
-  // Returns a bool if the node intersects the range.
-  if (!nodeValidForIntersects(refNode, m_ownerDocument.get(), exceptionState))
+  if (!hasSameRoot(*refNode))
     return false;
 
   ContainerNode* parentNode = refNode->parentNode();