Range object should check root node identify instead of inActiveDocument().

Range object should check root node identify instead of inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests in imported/wpt/dom/ranges/.

BUG=656459
Committed: https://crrev.com/8a2aa879982c582f811a9d9ef75286b8d27aab84
Cr-Commit-Position: refs/heads/master@{#425630}

[tkent, 2016-10-14 12:10:20]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 12:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-14 12:12:05]

Description was changed from

==========
Range object should not check inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

BUG=
==========

to

==========
Range object should not check inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

This CL fixes 1,323 failing tests.

BUG=
==========

[tkent, 2016-10-14 12:12:54]

Description was changed from

==========
Range object should not check inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

This CL fixes 1,323 failing tests.

BUG=
==========

to

==========
Range object should not check inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests.

BUG=
==========

[commit-bot: I haz the power, 2016-10-14 13:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 13:35:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2016-10-17 00:26:30]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 00:26:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-17 00:31:34]

Patchset #1 (id:1) has been deleted

[tkent, 2016-10-17 02:30:45]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 02:31:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-17 03:12:41]

Description was changed from

==========
Range object should not check inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests.

BUG=
==========

to

==========
Range object should check root node identify instead of inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests.

BUG=656459
==========

[tkent, 2016-10-17 03:34:37]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2016-10-17 03:34:38]

yosin@, would you review this please?

[tkent, 2016-10-17 03:34:52]

Patchset #1 (id:10001) has been deleted

[commit-bot: I haz the power, 2016-10-17 03:45:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 03:45:39]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-17 04:14:29]

yosin@chromium.org changed reviewers:
+ yosin@chromium.orgs/

[yosin_UTC9, 2016-10-17 04:14:30]

s/This CL fixes 1,323 failing tests./This CL fixes 1,323 failing tests in
wpt/dom/ranges/Range-set.html/

https://codereview.chromium.org/2416963007/diff/30001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/2416963007/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Range.cpp:255: if (node.isConnected() &&
m_start.container()->isConnected() &&
Q: Is it better to use isInTreeScope() == isConnected or isInShadowTree?

https://codereview.chromium.org/2416963007/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Range.cpp:258: return
commonAncestorContainer(m_start.container(), &node);
nit: Is
m_start.container()->treeScope().commonAncestorTreeScope(node.treeScope())
faster than commonAncestorContainer(Node*, Node*)?

[tkent, 2016-10-17 04:16:23]

Description was changed from

==========
Range object should check root node identify instead of inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests.

BUG=656459
==========

to

==========
Range object should check root node identify instead of inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests in imported/wpt/dom/ranges/.

BUG=656459
==========

[tkent, 2016-10-17 04:46:42]

tkent@chromium.org changed reviewers:
- yosin@chromium.orgs/

[tkent, 2016-10-17 04:46:50]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 04:47:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-10-17 04:48:03]

https://codereview.chromium.org/2416963007/diff/30001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/2416963007/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Range.cpp:255: if (node.isConnected() &&
m_start.container()->isConnected() &&
On 2016/10/17 at 04:14:30, Yosi_UTC9 wrote:
> Q: Is it better to use isInTreeScope() == isConnected or isInShadowTree?

Yeah, that's a good idea.  It improves the coverage of this fast-path.  Done in
Patch Set 2.

https://codereview.chromium.org/2416963007/diff/30001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Range.cpp:258: return
commonAncestorContainer(m_start.container(), &node);
On 2016/10/17 at 04:14:30, Yosi_UTC9 wrote:
> nit: Is
m_start.container()->treeScope().commonAncestorTreeScope(node.treeScope())
faster than commonAncestorContainer(Node*, Node*)?

The comparison doesn't make sense because we can't use commonAncestorTreeScope()
here.

[yosin_UTC9, 2016-10-17 04:56:32]

lgtm

[tkent, 2016-10-17 05:47:58]

The CQ bit was unchecked by tkent@chromium.org

[tkent, 2016-10-17 05:48:03]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-10-17 05:48:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 08:08:28]

Committed patchset #2 (id:50001)

[commit-bot: I haz the power, 2016-10-17 08:10:51]

Description was changed from

==========
Range object should check root node identify instead of inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests in imported/wpt/dom/ranges/.

BUG=656459
==========

to

==========
Range object should check root node identify instead of inActiveDocument().

https://dom.spec.whatwg.org/#dom-range-ispointinrange

According to the DOM standard, isPointInRange(), comparePoint(), and
intersectNode() should check root identity, not whether the specified node is in
an active document.

Thew new behavior matches to Firefox and Safari.

This CL fixes 1,323 failing tests in imported/wpt/dom/ranges/.

BUG=656459

Committed: https://crrev.com/8a2aa879982c582f811a9d9ef75286b8d27aab84
Cr-Commit-Position: refs/heads/master@{#425630}
==========

[commit-bot: I haz the power, 2016-10-17 08:10:52]

Patchset 2 (id:??) landed as
https://crrev.com/8a2aa879982c582f811a9d9ef75286b8d27aab84
Cr-Commit-Position: refs/heads/master@{#425630}