Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1469)

Issue 2416963003: VM: Save one bool when serializing library prefixes. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Save one bool when serializing library prefixes. When loading a snapshot all library prefixes should be considered not loaded. This makes code running from a JIT snapshot throw the correct error when using a deferred prefix before it is loaded. Also, update test status and avoid skipping tests. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/701b91eb3141f6afa1ee73d5d6fff9da7b719a1e

Patch Set 1 #

Patch Set 2 : more precises test status (avoid skipping tests) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -15 lines) Patch
M runtime/vm/clustered_snapshot.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +1 line, -2 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +56 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 2 months ago (2016-10-13 20:28:30 UTC) #2
rmacnak
lgtm
4 years, 2 months ago (2016-10-13 20:34:18 UTC) #4
Florian Schneider
4 years, 2 months ago (2016-10-13 20:36:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
701b91eb3141f6afa1ee73d5d6fff9da7b719a1e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698