Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/ash

Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/ash

CreateAppDict()'s return value is passed to Append(); just change
it to return a std::unique_ptr<base::Value> instead of a
base::Value*.

BUG=581865
Committed: https://crrev.com/454aa39f1d349a1ec7b2a82840ed4650f8ea81ff
Cr-Commit-Position: refs/heads/master@{#425413}

[dcheng, 2016-10-13 17:36:24]

dcheng@chromium.org changed reviewers:
+ oshima@chromium.org

[dcheng, 2016-10-13 17:36:27]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 17:36:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 18:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 18:04:42]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-10-14 18:25:02]

lgtm

I think the description should be something like

Switch from deprecated API to new API that returns unique_ptr<ListValue>.

[dcheng, 2016-10-14 18:30:38]

On 2016/10/14 18:25:02, oshima wrote:
> lgtm
> 
> I think the description should be something like
> 
> Switch from deprecated API to new API that returns unique_ptr<ListValue>.

FWIW, this is only used in a call to Append(), hence the general subject. I
basically did a compile of a CrOS build to see what broke when I removed the
Append(Value*) overload, fixed all the instances, and sharded the giant CL.

I've updated the CL description to mention the specific fix here, since this one
happens to be fairly targeted.

[dcheng, 2016-10-14 18:31:34]

Description was changed from

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/ash

BUG=581865
==========

to

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/ash

CreateAppDict()'s return value is passed to Append(); just change
it to return a std::unique_ptr<base::Value> instead of a
base::Value*.

BUG=581865
==========

[dcheng, 2016-10-14 18:31:39]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:33:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 19:06:37]

Description was changed from

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/ash

CreateAppDict()'s return value is passed to Append(); just change
it to return a std::unique_ptr<base::Value> instead of a
base::Value*.

BUG=581865
==========

to

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/ash

CreateAppDict()'s return value is passed to Append(); just change
it to return a std::unique_ptr<base::Value> instead of a
base::Value*.

BUG=581865
==========

[commit-bot: I haz the power, 2016-10-14 19:06:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-14 19:08:38]

Description was changed from

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/ash

CreateAppDict()'s return value is passed to Append(); just change
it to return a std::unique_ptr<base::Value> instead of a
base::Value*.

BUG=581865
==========

to

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/ash

CreateAppDict()'s return value is passed to Append(); just change
it to return a std::unique_ptr<base::Value> instead of a
base::Value*.

BUG=581865

Committed: https://crrev.com/454aa39f1d349a1ec7b2a82840ed4650f8ea81ff
Cr-Commit-Position: refs/heads/master@{#425413}
==========

[commit-bot: I haz the power, 2016-10-14 19:08:39]

Patchset 1 (id:??) landed as
https://crrev.com/454aa39f1d349a1ec7b2a82840ed4650f8ea81ff
Cr-Commit-Position: refs/heads/master@{#425413}