Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 24169006: Merged r16816 into trunk branch. (Closed)

Created:
7 years, 3 months ago by Hannes Payer (out of office)
Modified:
7 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Merged r16816 into trunk branch. Reverted ("Chromium 284577 needs a mitigation CL added." (svn-id 16742)). Also changed a check in heap-inl.h for diagnosing 284577 into an assert. R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M src/heap-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -12 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Hannes Payer (out of office)
7 years, 3 months ago (2013-09-19 09:57:13 UTC) #1
mvstanton
lgtm
7 years, 3 months ago (2013-09-19 09:58:46 UTC) #2
Hannes Payer (out of office)
7 years, 3 months ago (2013-09-19 09:59:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16822 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698