Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24169005: remove HEAP from tests (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -417 lines) Patch
M test/cctest/cctest.h View 2 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 72 chunks +129 lines, -126 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 15 chunks +15 lines, -15 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M test/cctest/test-decls.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-dictionary.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-global-handles.cc View 3 chunks +17 lines, -15 lines 0 comments Download
M test/cctest/test-heap.cc View 84 chunks +183 lines, -179 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-mark-compact.cc View 11 chunks +27 lines, -26 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-profile-generator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-spaces.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-19 09:42:47 UTC) #1
Sven Panne
LGTM (rubberstamped)
7 years, 3 months ago (2013-09-19 09:43:55 UTC) #2
dcarney
7 years, 3 months ago (2013-09-19 09:46:38 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r16819 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698