third_party/WebKit/Source/core/css/CSSConditionRule.idl - Issue 2416893002: CSSMediaRule and CSSSupportsRule inherit from CSSConditionRule

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/CSSConditionRule.idl

Issue 2416893002: CSSMediaRule and CSSSupportsRule inherit from CSSConditionRule (Closed)

Patch Set: Fix layout virtual tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module cc.mojom;	5 //https://drafts.csswg.org/css-conditional/#the-cssconditionrule-interface
	foolip 2016/10/14 08:36:44 An extra space here :) An extra space here :)
6	6

7 import "cc/ipc/filter_operation.mojom";	7 interface CSSConditionRule : CSSGroupingRule {

8	8 readonly attribute DOMString conditionText;
	foolip 2016/10/14 08:36:44 This is actually not readonly in the spec. You're This is actually not readonly in the spec. You're just preserving behavior, but can you add a TODO saying that it shouldn't be readonly? It could well be that the spec is wrong, if you could investigate if it's really mutable in any engine (whether or not they have this new interface) that'd be good. If it's not, then a spec bug would be in order.
9 // See cc/output/filter_operations.h.

10 struct FilterOperations {

11 array<cc.mojom.FilterOperation> operations;

12 };	9 };

13

OLD	NEW