Fixing naming issues in MediaSession

Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionPlayerObserver
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

Overall work description:
https://docs.google.com/a/google.com/document/d/1duLlKQ6Y8ogC9VUbDvdTz8-Rn45Mrove0uD5j089Le8/edit?usp=sharing

BUG=655781
Committed: https://crrev.com/a2147f8ab712703c6513078635fcacd595a88979
Cr-Commit-Position: refs/heads/master@{#426075}

[Zhiqiang Zhang (Slow), 2016-10-14 16:24:41]

Description was changed from

==========
Fixing namings in MediaSession

There are a handful of classes in media/session that have bad names which do not
match what these class really are. This CL fixes this naming issue:

- MediaSessionObserver -> MediaSessionController
- MediaSessionController -> MediaSessionControllerImpl
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

BUG=655781
==========

to

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad names which do not
match what these class really are. This CL fixes this naming issue:

- MediaSessionObserver -> MediaSessionController
- MediaSessionController -> MediaSessionControllerImpl
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

BUG=655781
==========

[Zhiqiang Zhang (Slow), 2016-10-14 16:25:22]

Description was changed from

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad names which do not
match what these class really are. This CL fixes this naming issue:

- MediaSessionObserver -> MediaSessionController
- MediaSessionController -> MediaSessionControllerImpl
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

BUG=655781
==========

to

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionController
- MediaSessionController -> MediaSessionControllerImpl
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

BUG=655781
==========

[Zhiqiang Zhang (Slow), 2016-10-14 18:46:26]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org, mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-14 18:46:27]

The initial renaming. Maybe there are some accidental style changes since I used
`git cl format` (maybe acceptable for this kind of patch?)

[Zhiqiang Zhang (Slow), 2016-10-14 18:46:32]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 18:47:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 18:53:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 18:53:17]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhiqiang Zhang (Slow), 2016-10-14 19:00:33]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 19:01:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 19:12:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 19:12:51]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[whywhat, 2016-10-14 23:51:25]

non-lgtm

let's agree on the renaming first, using the bug you filed

[whywhat, 2016-10-14 23:52:04]

On 2016/10/14 at 23:51:25, whywhat wrote:
> non-lgtm
> 
> let's agree on the renaming first, using the bug you filed

not lgtm?
what's the keyword here?
I now start liking gerrit a bit better :/

[Zhiqiang Zhang (Slow), 2016-10-17 23:11:58]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 23:12:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 00:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:54:57]

Dry run: This issue passed the CQ dry run.

[Zhiqiang Zhang (Slow), 2016-10-18 12:30:32]

Description was changed from

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionController
- MediaSessionController -> MediaSessionControllerImpl
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

BUG=655781
==========

to

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionPlayerObserver
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

BUG=655781
==========

[Zhiqiang Zhang (Slow), 2016-10-18 13:18:47]

Description was changed from

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionPlayerObserver
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

BUG=655781
==========

to

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionPlayerObserver
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

Overall work description:
https://docs.google.com/a/google.com/document/d/1duLlKQ6Y8ogC9VUbDvdTz8-Rn45M...

BUG=655781
==========

[Zhiqiang Zhang (Slow), 2016-10-18 13:24:14]

zqzhang@chromium.org changed reviewers:
+ boliu@chromium.org, sky@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-18 13:24:14]

PTAL
+boliu for JNI changes
+sky for RS content/test/BUILD.gn

Now the naming is as we agreed in offline discussion:
MediaSessionObserver->MediaSessionPlayerObserver
MediaSessionDelegate->AudioFocusDelegate

[boliu, 2016-10-18 15:54:41]

can you get Anton to approve first (so I don't have to look at the media things
at all :p)

[Zhiqiang Zhang (Slow), 2016-10-18 16:12:21]

On 2016/10/18 15:54:41, boliu wrote:
> can you get Anton to approve first (so I don't have to look at the media
things
> at all :p)

Sure :)

[sky, 2016-10-18 17:07:43]

content/test/BUILD.gn LGTM

[whywhat, 2016-10-18 18:11:45]

https://chromiumcodereview.appspot.com/2416853005/diff/80001/content/browser/...
File content/browser/media/session/audio_focus_delegate_android_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/2416853005/diff/80001/content/browser/...
content/browser/media/session/audio_focus_delegate_android_browsertest.cc:46:
media_session_player_observer->StartNewPlayer();
nit: you could use player_observer without losing much context but saving some
characters if you want.

[Zhiqiang Zhang (Slow), 2016-10-18 19:01:22]

https://chromiumcodereview.appspot.com/2416853005/diff/80001/content/browser/...
File content/browser/media/session/audio_focus_delegate_android_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/2416853005/diff/80001/content/browser/...
content/browser/media/session/audio_focus_delegate_android_browsertest.cc:46:
media_session_player_observer->StartNewPlayer();
On 2016/10/18 18:11:45, whywhat wrote:
> nit: you could use player_observer without losing much context but saving some
> characters if you want.

Done in a local patch. Will upload after codereview is fixed.

[Zhiqiang Zhang (Slow), 2016-10-18 20:06:08]

https://chromiumcodereview.appspot.com/2416853005/diff/80001/content/browser/...
File content/browser/media/session/audio_focus_delegate_android_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/2416853005/diff/80001/content/browser/...
content/browser/media/session/audio_focus_delegate_android_browsertest.cc:46:
media_session_player_observer->StartNewPlayer();
On 2016/10/18 19:01:22, Zhiqiang Zhang wrote:
> On 2016/10/18 18:11:45, whywhat wrote:
> > nit: you could use player_observer without losing much context but saving
some
> > characters if you want.
> 
> Done in a local patch. Will upload after codereview is fixed.

Uploaded. Anything else, Anton?

[whywhat, 2016-10-18 20:36:03]

lgtm

sorry lgtm got lost when switching from non-working codereview.chromium.org to
chromiumcodereview.appspot.com...

[boliu, 2016-10-18 20:41:08]

lgtm

[Zhiqiang Zhang (Slow), 2016-10-18 20:41:51]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 20:42:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 22:05:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 22:05:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Zhiqiang Zhang (Slow), 2016-10-18 22:10:42]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-18 22:10:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2416853005/#ps100001
(title: "addressed nits")

[commit-bot: I haz the power, 2016-10-18 22:11:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 22:53:58]

Description was changed from

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionPlayerObserver
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

Overall work description:
https://docs.google.com/a/google.com/document/d/1duLlKQ6Y8ogC9VUbDvdTz8-Rn45M...

BUG=655781
==========

to

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionPlayerObserver
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

Overall work description:
https://docs.google.com/a/google.com/document/d/1duLlKQ6Y8ogC9VUbDvdTz8-Rn45M...

BUG=655781
==========

[commit-bot: I haz the power, 2016-10-18 22:53:59]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-21 13:04:15]

Description was changed from

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionPlayerObserver
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

Overall work description:
https://docs.google.com/a/google.com/document/d/1duLlKQ6Y8ogC9VUbDvdTz8-Rn45M...

BUG=655781
==========

to

==========
Fixing naming issues in MediaSession

There are a handful of classes in media/session that have bad
names which do not match what these class really are. This CL
fixes this naming issue:

- MediaSessionObserver -> MediaSessionPlayerObserver
- MediaSessionDelegate -> AudioFocusDelegate (C++ & Android)

Overall work description:
https://docs.google.com/a/google.com/document/d/1duLlKQ6Y8ogC9VUbDvdTz8-Rn45M...

BUG=655781

Committed: https://crrev.com/a2147f8ab712703c6513078635fcacd595a88979
Cr-Commit-Position: refs/heads/master@{#426075}
==========

[commit-bot: I haz the power, 2016-10-21 13:04:17]

Patchset 6 (id:??) landed as
https://crrev.com/a2147f8ab712703c6513078635fcacd595a88979
Cr-Commit-Position: refs/heads/master@{#426075}