Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2416823003: [Sync] Move some things from core/ to model(_impl)/. (Closed)

Created:
4 years, 2 months ago by maxbogue
Modified:
4 years, 2 months ago
Reviewers:
skym, cmumford
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move some things from core/ to model(_impl)/. Everything is being moved out of core/ to better homes. model/ data_batch_impl -> mutable_data_batch model_type_store_test_util simple_metadata_change_list model_impl/ model_type_store_backend model_type_store_impl BUG=631271 Committed: https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97 Cr-Commit-Position: refs/heads/master@{#425354}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1774 lines) Patch
M components/sync/BUILD.gn View 8 chunks +14 lines, -14 lines 0 comments Download
D components/sync/core/data_batch_impl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D components/sync/core/data_batch_impl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D components/sync/core/data_batch_impl_unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D components/sync/core/model_type_store_backend.h View 1 chunk +0 lines, -108 lines 0 comments Download
D components/sync/core/model_type_store_backend.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D components/sync/core/model_type_store_backend_unittest.cc View 1 chunk +0 lines, -192 lines 0 comments Download
D components/sync/core/model_type_store_impl.h View 1 chunk +0 lines, -123 lines 0 comments Download
D components/sync/core/model_type_store_impl.cc View 1 chunk +0 lines, -343 lines 0 comments Download
D components/sync/core/model_type_store_impl_unittest.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D components/sync/core/simple_metadata_change_list.h View 1 chunk +0 lines, -66 lines 0 comments Download
D components/sync/core/simple_metadata_change_list.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D components/sync/core/simple_metadata_change_list_unittest.cc View 1 chunk +0 lines, -191 lines 0 comments Download
D components/sync/core/test/model_type_store_test_util.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/sync/core_impl/test/model_type_store_test_util.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M components/sync/device_info/device_info_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/device_info/device_info_service.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/device_info/device_info_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model/fake_model_type_service.cc View 1 3 chunks +6 lines, -4 lines 0 comments Download
M components/sync/model/model_type_store.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/model/model_type_store_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/model/model_type_store_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/model/mutable_data_batch.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + components/sync/model/mutable_data_batch.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + components/sync/model/mutable_data_batch_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + components/sync/model/simple_metadata_change_list.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/model/simple_metadata_change_list.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/model/simple_metadata_change_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model_impl/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + components/sync/model_impl/model_type_store_backend.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/model_impl/model_type_store_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/model_impl/model_type_store_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/sync/model_impl/model_type_store_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/sync/model_impl/model_type_store_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/sync/model_impl/model_type_store_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model_impl/shared_model_type_processor_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (13 generated)
maxbogue
Sky, PTAL!
4 years, 2 months ago (2016-10-13 21:15:25 UTC) #6
skym
lgtm
4 years, 2 months ago (2016-10-13 22:54:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416823003/20001
4 years, 2 months ago (2016-10-13 23:41:51 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/280884)
4 years, 2 months ago (2016-10-13 23:52:40 UTC) #14
maxbogue
+cmumford for third_party/leveldatabase DEP. Note that this just moves files and is not actually introducing ...
4 years, 2 months ago (2016-10-13 23:59:58 UTC) #16
cmumford
lgtm
4 years, 2 months ago (2016-10-14 15:46:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416823003/20001
4 years, 2 months ago (2016-10-14 15:54:34 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 16:43:17 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:47:28 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/233bfebf0ee3eed7e6a559b3314d60e873d85b97
Cr-Commit-Position: refs/heads/master@{#425354}

Powered by Google App Engine
This is Rietveld 408576698