Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2416803003: Record PendingTaskCount when a backgrounded renderer is suspended. (Closed)
Patch Set: Add unittest Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/renderer/renderer_scheduler_impl.h" 5 #include "platform/scheduler/renderer/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/stack_trace.h" 8 #include "base/debug/stack_trace.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 472 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 suspend_timers_when_backgrounded_closure_.Cancel(); 483 suspend_timers_when_backgrounded_closure_.Cancel();
484 ResumeTimerQueueWhenForegrounded(); 484 ResumeTimerQueueWhenForegrounded();
485 } 485 }
486 486
487 void RendererSchedulerImpl::SuspendRenderer() { 487 void RendererSchedulerImpl::SuspendRenderer() {
488 helper_.CheckOnValidThread(); 488 helper_.CheckOnValidThread();
489 DCHECK(MainThreadOnly().renderer_backgrounded); 489 DCHECK(MainThreadOnly().renderer_backgrounded);
490 if (helper_.IsShutdown()) 490 if (helper_.IsShutdown())
491 return; 491 return;
492 suspend_timers_when_backgrounded_closure_.Cancel(); 492 suspend_timers_when_backgrounded_closure_.Cancel();
493
494 UMA_HISTOGRAM_COUNTS("PurgeAndSuspend.PendingTaskCount",
495 GetNumberOfPendingTasks());
496
493 // TODO(hajimehoshi): We might need to suspend not only timer queue but also 497 // TODO(hajimehoshi): We might need to suspend not only timer queue but also
494 // e.g. loading tasks or postMessage. 498 // e.g. loading tasks or postMessage.
495 MainThreadOnly().renderer_suspended = true; 499 MainThreadOnly().renderer_suspended = true;
496 SuspendTimerQueueWhenBackgrounded(); 500 SuspendTimerQueueWhenBackgrounded();
497 } 501 }
498 502
503 int RendererSchedulerImpl::GetNumberOfPendingTasks() {
Sami 2016/10/14 01:38:18 I would suggest adding this getter into TaskQueueM
tasak 2016/10/14 05:55:32 I see. I agree that TaskQueueManager is the best c
504 int count = 0;
505 for (const scoped_refptr<TaskQueue>& loading_queue : loading_task_runners_)
506 count += loading_queue->GetNumberOfPendingTasks();
507 for (const scoped_refptr<TaskQueue>& timer_queue : timer_task_runners_)
508 count += timer_queue->GetNumberOfPendingTasks();
509 count += DefaultTaskRunner()->GetNumberOfPendingTasks();
510 count += CompositorTaskRunner()->GetNumberOfPendingTasks();
511 count += idle_helper_.GetNumberOfPendingIdleTasks();
512 return count;
513 }
514
499 void RendererSchedulerImpl::EndIdlePeriod() { 515 void RendererSchedulerImpl::EndIdlePeriod() {
500 if (MainThreadOnly().in_idle_period_for_testing) 516 if (MainThreadOnly().in_idle_period_for_testing)
501 return; 517 return;
502 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), 518 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
503 "RendererSchedulerImpl::EndIdlePeriod"); 519 "RendererSchedulerImpl::EndIdlePeriod");
504 helper_.CheckOnValidThread(); 520 helper_.CheckOnValidThread();
505 idle_helper_.EndIdlePeriod(); 521 idle_helper_.EndIdlePeriod();
506 } 522 }
507 523
508 void RendererSchedulerImpl::EndIdlePeriodForTesting( 524 void RendererSchedulerImpl::EndIdlePeriodForTesting(
(...skipping 1077 matching lines...) Expand 10 before | Expand all | Expand 10 after
1586 case v8::PERFORMANCE_LOAD: 1602 case v8::PERFORMANCE_LOAD:
1587 return "load"; 1603 return "load";
1588 default: 1604 default:
1589 NOTREACHED(); 1605 NOTREACHED();
1590 return nullptr; 1606 return nullptr;
1591 } 1607 }
1592 } 1608 }
1593 1609
1594 } // namespace scheduler 1610 } // namespace scheduler
1595 } // namespace blink 1611 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698