Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2416783007: Roll WebGL 1db74f6..4e6c509 (Closed)

Created:
4 years, 2 months ago by Kai Ninomiya
Modified:
4 years, 1 month ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebGL 1db74f6..4e6c509 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1db74f6..4e6c509 BUG=655836 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc Cr-Commit-Position: refs/heads/master@{#425541}

Patch Set 1 #

Patch Set 2 : update expectations #

Patch Set 3 : update expectations #

Patch Set 4 : update expectations #

Patch Set 5 : update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 4 2 chunks +26 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (23 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416783007/80001
4 years, 2 months ago (2016-10-15 02:15:27 UTC) #19
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-15 02:15:29 UTC) #21
kainino
zmo: ptal
4 years, 2 months ago (2016-10-15 02:16:51 UTC) #23
Zhenyao Mo
On 2016/10/15 02:16:51, kainino wrote: > zmo: ptal lgtm
4 years, 2 months ago (2016-10-15 02:54:54 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416783007/80001
4 years, 2 months ago (2016-10-15 02:55:05 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-15 03:00:29 UTC) #28
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc Cr-Commit-Position: refs/heads/master@{#425541}
4 years, 2 months ago (2016-10-15 03:02:13 UTC) #30
Michael Moss
On 2016/10/15 03:02:13, commit-bot: I haz the power wrote: > Patchset 5 (id:??) landed as ...
4 years, 2 months ago (2016-10-17 19:25:06 UTC) #31
Zhenyao Mo
On 2016/10/17 19:25:06, Michael Moss wrote: > On 2016/10/15 03:02:13, commit-bot: I haz the power ...
4 years, 2 months ago (2016-10-17 19:57:16 UTC) #32
Kai Ninomiya
4 years, 2 months ago (2016-10-17 20:12:17 UTC) #33
Message was sent while issue was closed.
On 2016/10/17 19:57:16, Zhenyao Mo wrote:
> On 2016/10/17 19:25:06, Michael Moss wrote:
> > On 2016/10/15 03:02:13, commit-bot: I haz the power wrote:
> > > Patchset 5 (id:??) landed as
> > > https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc
> > > Cr-Commit-Position: refs/heads/master@{#425541}
> > 
> > Not, this is breaking the release branching scripts because of the
> "incomplete"
> > hash. Please always use full commit hashes.
> 
> Note.  Didn't realize this is a problem.
> 
> kainino: you can use tools/roll_webgl_conformance.py to do the roll, so you
> won't ever trigger this issue

Huh, this is really weird! I did use the script, as usual. We're looking into
how this could have happened. Thanks mmoss!

Powered by Google App Engine
This is Rietveld 408576698