|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by Kai Ninomiya Modified:
4 years, 1 month ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll WebGL 1db74f6..4e6c509
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1db74f6..4e6c509
BUG=655836
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Committed: https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc
Cr-Commit-Position: refs/heads/master@{#425541}
Patch Set 1 #Patch Set 2 : update expectations #Patch Set 3 : update expectations #Patch Set 4 : update expectations #Patch Set 5 : update expectations #
Messages
Total messages: 33 (23 generated)
Description was changed from ========== Roll WebGL 1db74f6..4e6c509 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1db74f... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 1db74f6..4e6c509 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1db74f... BUG=655836 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kainino@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
kainino@google.com changed reviewers: + zmo@google.com - kainino@google.com
zmo: ptal
On 2016/10/15 02:16:51, kainino wrote: > zmo: ptal lgtm
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 1db74f6..4e6c509 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1db74f... BUG=655836 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 1db74f6..4e6c509 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1db74f... BUG=655836 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 1db74f6..4e6c509 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1db74f... BUG=655836 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel ========== to ========== Roll WebGL 1db74f6..4e6c509 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/1db74f... BUG=655836 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc Cr-Commit-Position: refs/heads/master@{#425541} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc Cr-Commit-Position: refs/heads/master@{#425541}
Message was sent while issue was closed.
On 2016/10/15 03:02:13, commit-bot: I haz the power wrote: > Patchset 5 (id:??) landed as > https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc > Cr-Commit-Position: refs/heads/master@{#425541} Not, this is breaking the release branching scripts because of the "incomplete" hash. Please always use full commit hashes.
Message was sent while issue was closed.
On 2016/10/17 19:25:06, Michael Moss wrote: > On 2016/10/15 03:02:13, commit-bot: I haz the power wrote: > > Patchset 5 (id:??) landed as > > https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc > > Cr-Commit-Position: refs/heads/master@{#425541} > > Not, this is breaking the release branching scripts because of the "incomplete" > hash. Please always use full commit hashes. Note. Didn't realize this is a problem. kainino: you can use tools/roll_webgl_conformance.py to do the roll, so you won't ever trigger this issue
Message was sent while issue was closed.
On 2016/10/17 19:57:16, Zhenyao Mo wrote: > On 2016/10/17 19:25:06, Michael Moss wrote: > > On 2016/10/15 03:02:13, commit-bot: I haz the power wrote: > > > Patchset 5 (id:??) landed as > > > https://crrev.com/0c6d81da9e9d679e15552d1429a638205410d2bc > > > Cr-Commit-Position: refs/heads/master@{#425541} > > > > Not, this is breaking the release branching scripts because of the > "incomplete" > > hash. Please always use full commit hashes. > > Note. Didn't realize this is a problem. > > kainino: you can use tools/roll_webgl_conformance.py to do the roll, so you > won't ever trigger this issue Huh, this is really weird! I did use the script, as usual. We're looking into how this could have happened. Thanks mmoss! |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
