Make the CPDFXFA_App non-global

Make the CPDFXFA_App non-global

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623
Committed: https://pdfium.googlesource.com/pdfium/+/abefb79577b32d291d14d7e01a70f6f8cf213bd3

[dsinclair, 2016-10-13 02:26:17]

Patchset #1 (id:1) has been deleted

[dsinclair, 2016-10-13 02:26:24]

Patchset #1 (id:20001) has been deleted

[dsinclair, 2016-10-13 02:26:36]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 02:26:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 02:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 02:31:36]

Dry run: Try jobs failed on following builders:
  linux_xfa on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_xfa/build...)

[dsinclair, 2016-10-13 14:14:05]

Description was changed from

==========
Make the CPDFXFA_App non-global

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.
==========

to

==========
Make the CPDFXFA_App non-global

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623
==========

[dsinclair, 2016-10-13 16:02:47]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 16:02:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 16:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 16:10:27]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-10-13 16:10:37]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-10-13 16:10:38]

PTAL.

tsepez@ there are a bunch of v8 isolate changes in here and I'm pretty shaky on
how those bits wire together. I know you've done a bunch of stuff around the
isolates so a bit of extra scrutiny is probably a good idea.

[Tom Sepez, 2016-10-13 16:34:13]

here's some background.  Both fpdfsdk (via fxjs) and xfa (via fxjse) want to use
v8, but its not clear which one is going to get invoked first.  Ideally, fpdfsdk
will go first and set up the environment, and xfa will just piggy-back off of
it.  But for some xfa documents, this never happens and the CPDFXFA_App gets
called into before JS is setup.

Because of this change, when we create an CPDFXFA_App, are we sure that FXJS is
already in existence?  If so, then this make things much saner.

[dsinclair, 2016-10-13 17:16:56]

On 2016/10/13 16:34:13, Tom Sepez wrote:
> here's some background.  Both fpdfsdk (via fxjs) and xfa (via fxjse) want to
use
> v8, but its not clear which one is going to get invoked first.  Ideally,
fpdfsdk
> will go first and set up the environment, and xfa will just piggy-back off of
> it.  But for some xfa documents, this never happens and the CPDFXFA_App gets
> called into before JS is setup.
> 
> Because of this change, when we create an CPDFXFA_App, are we sure that FXJS
is
> already in existence?  If so, then this make things much saner.

So, in the previous would fpdfview would call the CPDFXFA_App::Initialize method
during setup. With this new world, we'll only create a CPDFXFA_App if we've
already got a CPDFXFA_Document that we need to access methods on. You get a
CPDFXFA_Document through the various FPDF calls. So, I believe you should have
done all the proper initialization before attempting to work with a document.

[Tom Sepez, 2016-10-13 17:46:02]

Sound reasonable. LGTM

[dsinclair, 2016-10-13 17:48:03]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-10-13 17:48:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 17:48:24]

Description was changed from

==========
Make the CPDFXFA_App non-global

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623
==========

to

==========
Make the CPDFXFA_App non-global

This CL changes CPDFXFA_App from a global object to a child of the
CPDFXFA_Document objects.

BUG=pdfium:623

Committed:
https://pdfium.googlesource.com/pdfium/+/abefb79577b32d291d14d7e01a70f6f8cf21...
==========

[commit-bot: I haz the power, 2016-10-13 17:48:28]

Committed patchset #3 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/abefb79577b32d291d14d7e01a70f6f8cf21...

[dsinclair, 2016-10-13 17:56:52]

A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/2412903004/ by dsinclair@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/client.pdfium/builders/linux_xfa_asan_lsan/build...

msan is sad..