Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2416733002: split CPDF_StreamContentParser::AddImage() into 3 overloads. (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

split CPDF_StreamContentParser::AddImage() into 3 overloads. Small step before making CPDF_Image stream ownership saner. Committed: https://pdfium.googlesource.com/pdfium/+/d66f9d0b1fb0af57960f9c7163c475968505ee4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -32 lines) Patch
M core/fpdfapi/page/fpdf_page_parser.cpp View 5 chunks +43 lines, -29 lines 0 comments Download
M core/fpdfapi/page/pageint.h View 3 chunks +8 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Tom Sepez
lei, for review.
4 years, 2 months ago (2016-10-13 00:33:28 UTC) #4
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-13 00:46:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416733002/1
4 years, 2 months ago (2016-10-13 16:42:15 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 16:42:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d66f9d0b1fb0af57960f9c7163c475968505...

Powered by Google App Engine
This is Rietveld 408576698