[fsp] Initial implementation of timeout logic for requests.

chrome/browser/chromeos/file_system_provider/request_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
+#include "base/callback.h"
 #include "base/files/file.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/memory/weak_ptr.h"
+#include "base/run_loop.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/file_system_provider/request_manager.h"
+#include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 namespace file_system_provider {
 namespace {
 
 // Logs calls of the success and error callbacks on requests.
 class EventLogger {
  public:
   class SuccessEvent {
@@ skipping 38 matching lines @@
   base::WeakPtr<EventLogger> GetWeakPtr() {
     return weak_ptr_factory_.GetWeakPtr();
   }
 
  private:
   ScopedVector<SuccessEvent> success_events_;
   ScopedVector<ErrorEvent> error_events_;
   base::WeakPtrFactory<EventLogger> weak_ptr_factory_;
 };
 
+// Handles a request error due to a timeout. Registers the call in the logger
+// via |logger_callback| and quits a RunLoop instance with the |quit_closure|.
+void OnRequestTimeout(base::Callback<void(base::File::Error)> logger_callback,
+                      base::Closure quit_closure,
+                      base::File::Error error) {
+  logger_callback.Run(error);
+  quit_closure.Run();
+}
+
 }  // namespace
 
 class FileSystemProviderRequestManagerTest : public testing::Test {
  protected:
   FileSystemProviderRequestManagerTest() {}
   virtual ~FileSystemProviderRequestManagerTest() {}
 
   virtual void SetUp() OVERRIDE {
     request_manager_.reset(new RequestManager());
   }
 
+  content::TestBrowserThreadBundle thread_bundle_;
   scoped_ptr<RequestManager> request_manager_;
 };
 
 TEST_F(FileSystemProviderRequestManagerTest, CreateAndFulFill) {
   EventLogger logger;
 
   int request_id = request_manager_->CreateRequest(
       base::Bind(&EventLogger::OnSuccess, logger.GetWeakPtr()),
       base::Bind(&EventLogger::OnError, logger.GetWeakPtr()));
 
@@ skipping 202 matching lines @@
   }
 
   // All active requests should be aborted in the destructor of RequestManager.
   EventLogger::ErrorEvent* event = logger.error_events()[0];
   ASSERT_EQ(1u, logger.error_events().size());
   EXPECT_EQ(base::File::FILE_ERROR_ABORT, event->error());
 
   EXPECT_EQ(0u, logger.success_events().size());
 }
 
+TEST_F(FileSystemProviderRequestManagerTest, AbortOnTimeout) {
+  EventLogger logger;
+  base::RunLoop run_loop;
+
+  request_manager_->SetTimeoutForTests(100);

[hashimoto, 2014/04/18 05:28:09]

Can't we use 0 as the timeout?
Then you can use RunUntilIdle() because the run loop never becomes idle.

[mtomasz, 2014/04/18 05:56:18]

Good idea. Done.

+  int request_id = request_manager_->CreateRequest(
+      base::Bind(&EventLogger::OnSuccess, logger.GetWeakPtr()),
+      base::Bind(&OnRequestTimeout,
+                 base::Bind(&EventLogger::OnError, logger.GetWeakPtr()),
+                 run_loop.QuitClosure()));
+  EXPECT_LT(0, request_id);
+
+  // Wait until the request is timeouted. Note, that the entire test case will
+  // timeout if the request never timeouts.
+  run_loop.Run();
+
+  ASSERT_EQ(1u, logger.error_events().size());
+  EventLogger::ErrorEvent* event = logger.error_events()[0];
+  EXPECT_EQ(base::File::FILE_ERROR_ABORT, event->error());
+}
+
 }  // namespace file_system_provider
 }  // namespace chromeos