Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: extensions/common/features/base_feature_provider_unittest.cc

Issue 241673002: Support a "policy" extension location in extension features files. At the same (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: format Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/features/base_feature_provider_unittest.cc
diff --git a/extensions/common/features/base_feature_provider_unittest.cc b/extensions/common/features/base_feature_provider_unittest.cc
index 61a51625fee0ec92956d5a48ff2381975f0dd977..f856b35d3a2787cca787c02dd0229f216b081439 100644
--- a/extensions/common/features/base_feature_provider_unittest.cc
+++ b/extensions/common/features/base_feature_provider_unittest.cc
@@ -170,29 +170,33 @@ TEST(BaseFeatureProviderTest, ComplexFeatures) {
// Make sure both rules are applied correctly.
{
ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_BETA);
- EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- "1",
- Manifest::TYPE_EXTENSION,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM).result());
- EXPECT_EQ(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- "2",
- Manifest::TYPE_LEGACY_PACKAGED_APP,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM).result());
+ EXPECT_EQ(
+ Feature::IS_AVAILABLE,
+ feature->IsAvailableToManifest("1",
+ Manifest::TYPE_EXTENSION,
+ Manifest::INVALID_LOCATION,
+ Feature::UNSPECIFIED_PLATFORM).result());
+ EXPECT_EQ(
+ Feature::IS_AVAILABLE,
+ feature->IsAvailableToManifest("2",
+ Manifest::TYPE_LEGACY_PACKAGED_APP,
+ Manifest::INVALID_LOCATION,
+ Feature::UNSPECIFIED_PLATFORM).result());
}
{
ScopedCurrentChannel current_channel(VersionInfo::CHANNEL_STABLE);
- EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- "1",
- Manifest::TYPE_EXTENSION,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM).result());
- EXPECT_NE(Feature::IS_AVAILABLE, feature->IsAvailableToManifest(
- "2",
- Manifest::TYPE_LEGACY_PACKAGED_APP,
- Feature::UNSPECIFIED_LOCATION,
- Feature::UNSPECIFIED_PLATFORM).result());
+ EXPECT_NE(
+ Feature::IS_AVAILABLE,
+ feature->IsAvailableToManifest("1",
+ Manifest::TYPE_EXTENSION,
+ Manifest::INVALID_LOCATION,
+ Feature::UNSPECIFIED_PLATFORM).result());
+ EXPECT_NE(
+ Feature::IS_AVAILABLE,
+ feature->IsAvailableToManifest("2",
+ Manifest::TYPE_LEGACY_PACKAGED_APP,
+ Manifest::INVALID_LOCATION,
+ Feature::UNSPECIFIED_PLATFORM).result());
}
}
« no previous file with comments | « chrome/common/extensions/features/chrome_channel_feature_filter.cc ('k') | extensions/common/features/complex_feature.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698