Support a "policy" extension location in extension features files. At the same

extensions/common/features/feature.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_COMMON_FEATURES_FEATURE_H_
 #define EXTENSIONS_COMMON_FEATURES_FEATURE_H_
 
 #include <set>
 #include <string>
 
@@ skipping 28 matching lines @@
 
     // A normal web page. This should have an associated URL matching pattern.
     WEB_PAGE_CONTEXT,
 
     // A web page context which has been blessed by the user. Typically this
     // will be via the installation of a hosted app, so this may host an
     // extension. This is not affected by the URL matching pattern.
     BLESSED_WEB_PAGE_CONTEXT,
   };
 
-  // The location required of extensions the feature is supported in.
-  enum Location {
-    UNSPECIFIED_LOCATION,
-    COMPONENT_LOCATION
-  };
-
   // The platforms the feature is supported in.
   enum Platform {
     UNSPECIFIED_PLATFORM,
     CHROMEOS_PLATFORM,
     LINUX_PLATFORM,
     MACOSX_PLATFORM,
     WIN_PLATFORM
   };
 
   // Whether a feature is available in a given situation or not, and if not,
@@ skipping 40 matching lines @@
                                          const std::string& message);
 
   const std::string& name() const { return name_; }
   void set_name(const std::string& name) { name_ = name; }
   const std::set<std::string>& dependencies() const { return dependencies_; }
   bool no_parent() const { return no_parent_; }
 
   // Gets the platform the code is currently running on.
   static Platform GetCurrentPlatform();
 
-  // Gets the Feature::Location value for the specified Manifest::Location.
-  static Location ConvertLocation(Manifest::Location extension_location);
-
   virtual std::set<Context>* GetContexts() = 0;
 
   // Tests whether this is an internal API or not.
   virtual bool IsInternal() const = 0;
 
   // Returns True for features excluded from service worker backed contexts.
   virtual bool IsBlockedInServiceWorker() const = 0;
 
   // Returns true if the feature is available to be parsed into a new extension
   // manifest.
   Availability IsAvailableToManifest(const std::string& extension_id,
                                      Manifest::Type type,
-                                     Location location,
+                                     Manifest::Location location,
                                      int manifest_version) const {
     return IsAvailableToManifest(extension_id, type, location, manifest_version,
                                  GetCurrentPlatform());
   }
   virtual Availability IsAvailableToManifest(const std::string& extension_id,
                                              Manifest::Type type,
-                                             Location location,
+                                             Manifest::Location location,
                                              int manifest_version,
                                              Platform platform) const = 0;
 
+  // Returns true if the feature is available to |extension|.
+  Availability IsAvailableToExtension(const Extension* extension);

[not at google - send to devlin, 2014/04/17 21:33:14]

always irritated me that we don't have this.

+
   // Returns true if the feature is available to be used in the specified
   // extension and context.
   Availability IsAvailableToContext(const Extension* extension,
                                     Context context,
                                     const GURL& url) const {
     return IsAvailableToContext(extension, context, url, GetCurrentPlatform());
   }
   virtual Availability IsAvailableToContext(const Extension* extension,
                                             Context context,
                                             const GURL& url,
                                             Platform platform) const = 0;
 
   virtual std::string GetAvailabilityMessage(AvailabilityResult result,
                                              Manifest::Type type,
                                              const GURL& url,
                                              Context context) const = 0;
 
   virtual bool IsIdInWhitelist(const std::string& extension_id) const = 0;
 
  protected:
   std::string name_;
   std::set<std::string> dependencies_;
   bool no_parent_;
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_COMMON_FEATURES_FEATURE_H_