Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1488)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2416723002: Load live version when pulling down to reload an offline page on connected network (Closed)
Patch Set: Address one more feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 1dad91490f8f9a7ef446a422a1c4ee25131e2d72..4f2ead53de8ea18a0b7c00870b672f68a02b7416 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -1836,8 +1836,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
}
mInfoBarContainer.setContentViewCore(mContentViewCore);
- mSwipeRefreshHandler = new SwipeRefreshHandler(mThemedApplicationContext);
- mSwipeRefreshHandler.setContentViewCore(mContentViewCore);
+ mSwipeRefreshHandler = new SwipeRefreshHandler(mThemedApplicationContext, this);
updateThemeColorIfNeeded(false);
notifyContentChanged();
@@ -2350,7 +2349,7 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
mInfoBarContainer.setContentViewCore(null);
}
if (mSwipeRefreshHandler != null) {
- mSwipeRefreshHandler.setContentViewCore(null);
+ mSwipeRefreshHandler.destroy();
mSwipeRefreshHandler = null;
}
mContentViewParent = null;
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/SwipeRefreshHandler.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698