Optimize roll operator in CPDF_PSEngine some more.

Optimize roll operator in CPDF_PSEngine some more.

Also move code that belongs in an anonymous namespace into one.

Committed: https://pdfium.googlesource.com/pdfium/+/20f8ecc2f44332792c11cf0ac566c0114712b83c

[Lei Zhang, 2016-10-12 23:04:02]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 23:04:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 23:11:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 23:11:38]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-12 23:24:02]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2016-10-12 23:24:02]

Finally a use for std::rotate().

[Tom Sepez, 2016-10-13 16:21:31]

https://codereview.chromium.org/2416703002/diff/1/core/fpdfapi/page/fpdf_page...
File core/fpdfapi/page/fpdf_page_func.cpp (right):

https://codereview.chromium.org/2416703002/diff/1/core/fpdfapi/page/fpdf_page...
core/fpdfapi/page/fpdf_page_func.cpp:26: const struct PDF_PSOpName {
nit: as long as we're moving this, can we split this into two parts

struct PDF_PSOpName {...};
const PDF_PSOpName g_PSOpNames[] = {{...}};

or whatever ...

https://codereview.chromium.org/2416703002/diff/1/core/fpdfapi/page/fpdf_page...
core/fpdfapi/page/fpdf_page_func.cpp:466: auto end_it = begin_it + n;
Maybe it's easier to compute end_it first as
   std::begin() + m_StackCount
then begin_it = end_it - n;

https://codereview.chromium.org/2416703002/diff/1/core/fpdfapi/page/fpdf_page...
core/fpdfapi/page/fpdf_page_func.cpp:467: auto middle_it = begin_it - j;
I'm confused.  Middle comes before begin?

[Lei Zhang, 2016-10-13 22:48:19]

https://codereview.chromium.org/2416703002/diff/1/core/fpdfapi/page/fpdf_page...
File core/fpdfapi/page/fpdf_page_func.cpp (right):

https://codereview.chromium.org/2416703002/diff/1/core/fpdfapi/page/fpdf_page...
core/fpdfapi/page/fpdf_page_func.cpp:26: const struct PDF_PSOpName {
On 2016/10/13 16:21:30, Tom Sepez wrote:
> nit: as long as we're moving this, can we split this into two parts
> 
> struct PDF_PSOpName {...};
> const PDF_PSOpName g_PSOpNames[] = {{...}};
> 
> or whatever ...

Done.

https://codereview.chromium.org/2416703002/diff/1/core/fpdfapi/page/fpdf_page...
core/fpdfapi/page/fpdf_page_func.cpp:466: auto end_it = begin_it + n;
On 2016/10/13 16:21:30, Tom Sepez wrote:
> Maybe it's easier to compute end_it first as
>    std::begin() + m_StackCount
> then begin_it = end_it - n;

I was trying to keep the arguments to std::rotate() in order. I just wrote it
out for what it is.

https://codereview.chromium.org/2416703002/diff/1/core/fpdfapi/page/fpdf_page...
core/fpdfapi/page/fpdf_page_func.cpp:467: auto middle_it = begin_it - j;
On 2016/10/13 16:21:30, Tom Sepez wrote:
> I'm confused.  Middle comes before begin?

|j| is always negative here. I had it as an addition, but then I had to write:

j = (j > 0) ? n - j : -j;

[Tom Sepez, 2016-10-13 22:50:13]

lgtm

[Lei Zhang, 2016-10-13 22:53:14]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:53:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 23:05:41]

Description was changed from

==========
Optimize roll operator in CPDF_PSEngine some more.

Also move code that belongs in an anonymous namespace into one.
==========

to

==========
Optimize roll operator in CPDF_PSEngine some more.

Also move code that belongs in an anonymous namespace into one.

Committed:
https://pdfium.googlesource.com/pdfium/+/20f8ecc2f44332792c11cf0ac566c0114712...
==========

[commit-bot: I haz the power, 2016-10-13 23:05:42]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/20f8ecc2f44332792c11cf0ac566c0114712...