Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2416653002: Expand warning suppression in service_process_util_mac.mm. (Closed)

Created:
4 years, 2 months ago by erikchen
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expand warning suppression in service_process_util_mac.mm. There are two deprecated methods being called side by side. The warning suppression incorrectly only targetd one of the two methods. BUG=650801 Committed: https://crrev.com/a91e106df6f335cfdf7602c8bda6804c4eff74a6 Cr-Commit-Position: refs/heads/master@{#424865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/service_process_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
erikchen
thestig: Please review.
4 years, 2 months ago (2016-10-12 20:27:00 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-12 20:56:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416653002/1
4 years, 2 months ago (2016-10-12 20:56:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 21:31:21 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:34:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a91e106df6f335cfdf7602c8bda6804c4eff74a6
Cr-Commit-Position: refs/heads/master@{#424865}

Powered by Google App Engine
This is Rietveld 408576698