Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2416633002: Remove FOR_EACH_OBSERVER from arc/ since it's being deprecated (Closed)

Created:
4 years, 2 months ago by Yusuke Sato
Modified:
4 years, 2 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FOR_EACH_OBSERVER from arc/ since it's being deprecated BUG=655021 TEST=try, ARC still starts Committed: https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6 Cr-Commit-Position: refs/heads/master@{#424819}

Patch Set 1 #

Patch Set 2 : remove braces #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -58 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 6 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 1 16 chunks +36 lines, -32 lines 0 comments Download
M components/arc/arc_bridge_bootstrap.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 1 1 chunk +7 lines, -4 lines 1 comment Download
M components/arc/instance_holder.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M components/arc/intent_helper/link_handler_model_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/arc/test/fake_arc_bridge_bootstrap.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M ui/arc/notification/arc_custom_notification_item.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ui/arc/notification/arc_notification_surface_manager.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
Yusuke Sato
PTAL
4 years, 2 months ago (2016-10-12 17:55:45 UTC) #4
Luis Héctor Chávez
general: braces are also optional in one-line for loops. It also looks nicer and is ...
4 years, 2 months ago (2016-10-12 18:05:29 UTC) #8
xiyuan
lgtm
4 years, 2 months ago (2016-10-12 18:24:40 UTC) #9
Yusuke Sato
Thanks Xiyuan. Luis, PTAL. https://codereview.chromium.org/2416633002/diff/20001/components/arc/arc_bridge_service.cc File components/arc/arc_bridge_service.cc (right): https://codereview.chromium.org/2416633002/diff/20001/components/arc/arc_bridge_service.cc#newcode80 components/arc/arc_bridge_service.cc:80: for (auto& observer : observer_list()) ...
4 years, 2 months ago (2016-10-12 18:30:35 UTC) #12
Luis Héctor Chávez
Thanks for being proactive about this! lgtm
4 years, 2 months ago (2016-10-12 18:40:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416633002/20001
4 years, 2 months ago (2016-10-12 19:18:05 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 19:24:40 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 19:26:44 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e2934b8ab27cbab3c507df708a91c75c0ff19c6
Cr-Commit-Position: refs/heads/master@{#424819}

Powered by Google App Engine
This is Rietveld 408576698