Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2416573002: [test] Increase buffer for reading memory usage. (Closed)

Created:
4 years, 2 months ago by miran.karic
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Increase buffer for reading memory usage. When the test is executed in user mode qemu for mips64, it fails because the buffer is too small. Increasing the buffer fixes the problem. BUG= TEST=cctest/test-mark-compact/RegressJoinThreadsOnIsolateDeinit Committed: https://crrev.com/86fcace5b4b7f78b554ccc60dfe8ad512feb38bd Cr-Commit-Position: refs/heads/master@{#40278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/heap/test-mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
miran.karic
Short fix, PTAL
4 years, 2 months ago (2016-10-12 13:26:38 UTC) #2
Benedikt Meurer
LGTM.
4 years, 2 months ago (2016-10-13 11:04:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416573002/1
4 years, 2 months ago (2016-10-13 14:34:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 15:17:52 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 15:18:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86fcace5b4b7f78b554ccc60dfe8ad512feb38bd
Cr-Commit-Position: refs/heads/master@{#40278}

Powered by Google App Engine
This is Rietveld 408576698