Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2416553002: Convert set{End,Start}RespectingGranularity() in VisibleSlection as pure functions (Closed)

Created:
4 years, 2 months ago by yosin_UTC9
Modified:
4 years, 2 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert set{End,Start}RespectingGranularity() in VisibleSlection as pure functions This patch converts |set{End,Start}RespectingGranularity()| in |VisibleSlection| to pure functions for improving readability. This patch is intended to help debugging http://crbug.com/654710, e.g. checking positions before/after expanding selection by granularity in selection. BUG=654710 TEST=n/a; no behavior changes Committed: https://crrev.com/97263d0bef05d9dfe570d49516d916bba9ca95cc Cr-Commit-Position: refs/heads/master@{#424947}

Patch Set 1 : 2016-10-12T18:55:02 #

Patch Set 2 : 2016-10-12T19:51:30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -125 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 5 chunks +103 lines, -123 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yosin_UTC9
PTAL
4 years, 2 months ago (2016-10-13 01:06:13 UTC) #9
Xiaocheng
lgtm
4 years, 2 months ago (2016-10-13 02:09:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416553002/20001
4 years, 2 months ago (2016-10-13 03:30:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 03:37:20 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 03:40:36 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97263d0bef05d9dfe570d49516d916bba9ca95cc
Cr-Commit-Position: refs/heads/master@{#424947}

Powered by Google App Engine
This is Rietveld 408576698