Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/wasm/wasm-interpreter.cc

Issue 2416543002: [wasm] Fix bounds check for zero initial memory. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/assembler.cc ('K') | « src/compiler/x87/code-generator-x87.cc ('k') | src/wasm/wasm-module.cc » ('j') | test/cctest/compiler/test-run-wasm-machops.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-interpreter.cc
diff --git a/src/wasm/wasm-interpreter.cc b/src/wasm/wasm-interpreter.cc
index 8064bf2765c71c483c743092aa638fb4075e58ee..530ab67d99af4a3651225e001f5faa6406d7afbd 100644
--- a/src/wasm/wasm-interpreter.cc
+++ b/src/wasm/wasm-interpreter.cc
@@ -668,7 +668,6 @@ static inline int32_t ExecuteGrowMemory(uint32_t delta_pages,
if (delta_pages > wasm::WasmModule::kMaxMemPages) {
return -1;
}
- // TODO(gdeepti): Fix bounds check to take into account size of memtype.
new_size = delta_pages * wasm::WasmModule::kPageSize;
new_mem_start = static_cast<byte*>(calloc(new_size, sizeof(byte)));
if (!new_mem_start) {
« src/assembler.cc ('K') | « src/compiler/x87/code-generator-x87.cc ('k') | src/wasm/wasm-module.cc » ('j') | test/cctest/compiler/test-run-wasm-machops.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698