src/compiler/arm/code-generator-arm.cc - Issue 2416543002: [wasm] Fix bounds check for zero initial memory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm/code-generator-arm.cc

Issue 2416543002: [wasm] Fix bounds check for zero initial memory. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/arm/code-generator-arm.cc

diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc

index dbe182802ac7caecdbb617c97b7175ae6e8f6981..786aa6dca3f3a148557f0b35ab895000fbc18fd9 100644

--- a/src/compiler/arm/code-generator-arm.cc

+++ b/src/compiler/arm/code-generator-arm.cc

@@ -1816,7 +1816,7 @@ void CodeGenerator::AssembleMove(InstructionOperand* source,

case Constant::kInt32:

if (src.rmode() == RelocInfo::WASM_MEMORY_REFERENCE ||

src.rmode() == RelocInfo::WASM_GLOBAL_REFERENCE ||

- src.rmode() == RelocInfo::WASM_MEMORY_SIZE_REFERENCE) {

+ RelocInfo::IsWasmMemorySizeReference(src.rmode())) {

__ mov(dst, Operand(src.ToInt32(), src.rmode()));

} else {

__ mov(dst, Operand(src.ToInt32()));