Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/assembler.cc

Issue 2416543002: [wasm] Fix bounds check for zero initial memory. (Closed)
Patch Set: Add aTODO Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
781 case DEBUG_BREAK_SLOT_AT_TAIL_CALL: 781 case DEBUG_BREAK_SLOT_AT_TAIL_CALL:
782 return "debug break slot at tail call"; 782 return "debug break slot at tail call";
783 case CODE_AGE_SEQUENCE: 783 case CODE_AGE_SEQUENCE:
784 return "code age sequence"; 784 return "code age sequence";
785 case GENERATOR_CONTINUATION: 785 case GENERATOR_CONTINUATION:
786 return "generator continuation"; 786 return "generator continuation";
787 case WASM_MEMORY_REFERENCE: 787 case WASM_MEMORY_REFERENCE:
788 return "wasm memory reference"; 788 return "wasm memory reference";
789 case WASM_MEMORY_SIZE_REFERENCE: 789 case WASM_MEMORY_SIZE_REFERENCE:
790 return "wasm memory size reference"; 790 return "wasm memory size reference";
791 case WASM_MEMTYPE_SIZE_REFERENCE:
792 return "wasm memtype size reference";
791 case WASM_GLOBAL_REFERENCE: 793 case WASM_GLOBAL_REFERENCE:
792 return "wasm global value reference"; 794 return "wasm global value reference";
793 case NUMBER_OF_MODES: 795 case NUMBER_OF_MODES:
794 case PC_JUMP: 796 case PC_JUMP:
795 UNREACHABLE(); 797 UNREACHABLE();
796 return "number_of_modes"; 798 return "number_of_modes";
797 } 799 }
798 return "unknown relocation type"; 800 return "unknown relocation type";
799 } 801 }
800 802
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
879 case DEOPT_ID: 881 case DEOPT_ID:
880 case CONST_POOL: 882 case CONST_POOL:
881 case VENEER_POOL: 883 case VENEER_POOL:
882 case DEBUG_BREAK_SLOT_AT_POSITION: 884 case DEBUG_BREAK_SLOT_AT_POSITION:
883 case DEBUG_BREAK_SLOT_AT_RETURN: 885 case DEBUG_BREAK_SLOT_AT_RETURN:
884 case DEBUG_BREAK_SLOT_AT_CALL: 886 case DEBUG_BREAK_SLOT_AT_CALL:
885 case DEBUG_BREAK_SLOT_AT_TAIL_CALL: 887 case DEBUG_BREAK_SLOT_AT_TAIL_CALL:
886 case GENERATOR_CONTINUATION: 888 case GENERATOR_CONTINUATION:
887 case WASM_MEMORY_REFERENCE: 889 case WASM_MEMORY_REFERENCE:
888 case WASM_MEMORY_SIZE_REFERENCE: 890 case WASM_MEMORY_SIZE_REFERENCE:
891 case WASM_MEMTYPE_SIZE_REFERENCE:
889 case WASM_GLOBAL_REFERENCE: 892 case WASM_GLOBAL_REFERENCE:
890 case NONE32: 893 case NONE32:
891 case NONE64: 894 case NONE64:
892 break; 895 break;
893 case NUMBER_OF_MODES: 896 case NUMBER_OF_MODES:
894 case PC_JUMP: 897 case PC_JUMP:
895 UNREACHABLE(); 898 UNREACHABLE();
896 break; 899 break;
897 case CODE_AGE_SEQUENCE: 900 case CODE_AGE_SEQUENCE:
898 DCHECK(Code::IsYoungSequence(isolate, pc_) || code_age_stub()->IsCode()); 901 DCHECK(Code::IsYoungSequence(isolate, pc_) || code_age_stub()->IsCode());
(...skipping 1040 matching lines...) Expand 10 before | Expand all | Expand 10 after
1939 1942
1940 1943
1941 void Assembler::DataAlign(int m) { 1944 void Assembler::DataAlign(int m) {
1942 DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m)); 1945 DCHECK(m >= 2 && base::bits::IsPowerOfTwo32(m));
1943 while ((pc_offset() & (m - 1)) != 0) { 1946 while ((pc_offset() & (m - 1)) != 0) {
1944 db(0); 1947 db(0);
1945 } 1948 }
1946 } 1949 }
1947 } // namespace internal 1950 } // namespace internal
1948 } // namespace v8 1951 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698