Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2416513003: Fix issues with argument evaluation order and noSuchMethod errors. (Closed)

Created:
4 years, 2 months ago by Florian Schneider
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix issues with argument evaluation order and noSuchMethod errors. Fix tests to conform to spec bahavior. Update dart2js test status. BUG=#27572 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d99229026ee0c39b76b0966b36842101c214d108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -43 lines) Patch
M runtime/lib/mirrors.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +16 lines, -26 lines 0 comments Download
M tests/language/deferred_not_loaded_check_test.dart View 6 chunks +11 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/regress_27572_test.dart View 1 chunk +8 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 2 months ago (2016-10-12 22:20:15 UTC) #3
rmacnak
lgtm
4 years, 2 months ago (2016-10-12 22:50:51 UTC) #4
Florian Schneider
4 years, 2 months ago (2016-10-13 00:05:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d99229026ee0c39b76b0966b36842101c214d108 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698