Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2416513002: Mac: Fix SDK 10.11 build error from r424609. (Closed)

Created:
4 years, 2 months ago by tapted
Modified:
4 years, 2 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix SDK 10.11 build error from r424609. BUG=605219 TBR=eugenebut@chromium.org Committed: https://crrev.com/1bee8df0bab836996dbdddd4e6817f11f3bae320 Cr-Commit-Position: refs/heads/master@{#424685}

Patch Set 1 #

Patch Set 2 : Forward declare NSLayoutXAxisAnchor #

Patch Set 3 : Duck typing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.mm View 1 2 2 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416513002/1
4 years, 2 months ago (2016-10-12 04:37:57 UTC) #7
Eugene But (OOO till 7-30)
lgtm, thanks for the fix!
4 years, 2 months ago (2016-10-12 04:40:13 UTC) #8
yunchao
On 2016/10/12 04:40:13, Eugene But wrote: > lgtm, thanks for the fix! It works on ...
4 years, 2 months ago (2016-10-12 05:00:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/284513)
4 years, 2 months ago (2016-10-12 05:16:12 UTC) #11
Eugene But (OOO till 7-30)
lgtm!
4 years, 2 months ago (2016-10-12 06:22:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416513002/40001
4 years, 2 months ago (2016-10-12 06:27:18 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-12 07:12:00 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 07:13:30 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1bee8df0bab836996dbdddd4e6817f11f3bae320
Cr-Commit-Position: refs/heads/master@{#424685}

Powered by Google App Engine
This is Rietveld 408576698