Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: webkit/renderer/compositor_bindings/web_animation_impl.h

Issue 24165003: Don't clone WebAnimation in WebLayerImpl::addAnimation(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/renderer/compositor_bindings/web_animation_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/renderer/compositor_bindings/web_animation_impl.h
diff --git a/webkit/renderer/compositor_bindings/web_animation_impl.h b/webkit/renderer/compositor_bindings/web_animation_impl.h
index faedf905b3a7d0177f9b4b6a6d27ccafc699dd77..e6413cfbb6ad4f7c5011f71e8126d056eb9c6ae0 100644
--- a/webkit/renderer/compositor_bindings/web_animation_impl.h
+++ b/webkit/renderer/compositor_bindings/web_animation_impl.h
@@ -5,6 +5,7 @@
#ifndef WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_ANIMATION_IMPL_H_
#define WEBKIT_RENDERER_COMPOSITOR_BINDINGS_WEB_ANIMATION_IMPL_H_
+#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "third_party/WebKit/public/platform/WebAnimation.h"
#include "webkit/renderer/compositor_bindings/webkit_compositor_bindings_export.h"
@@ -36,9 +37,14 @@ class WebAnimationImpl : public WebKit::WebAnimation {
virtual bool alternatesDirection() const;
virtual void setAlternatesDirection(bool alternates);
- scoped_ptr<cc::Animation> CloneToAnimation();
+ scoped_ptr<cc::Animation> PassAnimation();
private:
+ cc::Animation* Animation() const {
jamesr 2013/09/23 18:09:31 this doesn't seem all that useful to me - when you
+ DCHECK(animation_);
+ return animation_.get();
+ }
+
scoped_ptr<cc::Animation> animation_;
DISALLOW_COPY_AND_ASSIGN(WebAnimationImpl);
« no previous file with comments | « no previous file | webkit/renderer/compositor_bindings/web_animation_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698