Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 24165002: Disable TestScriptInjected browser_test (Closed)

Created:
7 years, 3 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 3 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Disable TestScriptInjected browser_test It fails with Aura enabled, but it is the only one to do so. BUG=292299 TBR=mpcomplete Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/extensions/activity_log/activity_log_browsertest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cpu_(ooo_6.6-7.5)
I should mention, only on XP. strange.
7 years, 3 months ago (2013-09-16 02:49:02 UTC) #1
cpu_(ooo_6.6-7.5)
Committed patchset #1 manually as r223302.
7 years, 3 months ago (2013-09-16 02:50:27 UTC) #2
cpu_(ooo_6.6-7.5)
it passed in the next run before this change went in http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%28dbg%29%283%29&number=39600 So it might ...
7 years, 3 months ago (2013-09-16 04:16:48 UTC) #3
cpu_(ooo_6.6-7.5)
that link was broken, lets try again http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%28dbg%29%283%29&number=39600
7 years, 3 months ago (2013-09-16 04:18:08 UTC) #4
felt
7 years, 3 months ago (2013-09-16 04:21:08 UTC) #5
Message was sent while issue was closed.
On 2013/09/16 04:16:48, cpu wrote:
> it passed in the next run before this change went in
> 
>
http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%2520Tests%252...
> 
> So it might have been premature. I'll investigate.

Thanks Carlos. Can you also update crbug.com/292300 if you find anything? I
filed a bug specifically for this problem as well, in case the problem is with
our test and not a flaky bot.

Powered by Google App Engine
This is Rietveld 408576698