components/cronet/android/test/cronet_url_request_context_config_test.cc - Issue 2416473004: Add functionality for embedders to configure NQE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/cronet_url_request_context_config_test.cc

Issue 2416473004: Add functionality for embedders to configure NQE (Closed)

Patch Set: mgersh comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/cronet_url_request_context_adapter.cc ('k') | components/cronet/android/test/javatests/src/org/chromium/net/NQETest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/cronet_url_request_context_config_test.cc

diff --git a/components/cronet/android/test/cronet_url_request_context_config_test.cc b/components/cronet/android/test/cronet_url_request_context_config_test.cc

index ad522b74dcc4168ca8ab56be484252ef262f99f9..6b0d1bee82bec2d31c1be784c65e4c167d90dddf 100644

--- a/components/cronet/android/test/cronet_url_request_context_config_test.cc

+++ b/components/cronet/android/test/cronet_url_request_context_config_test.cc

@@ -43,7 +43,7 @@ static void VerifyUrlRequestContextConfig(

CHECK_EQ(config->http_cache, URLRequestContextConfig::HttpCacheType::MEMORY);

CHECK_EQ(config->http_cache_max_size, 54321);

CHECK_EQ(config->user_agent, "efgh");

- CHECK_EQ(config->experimental_options, "ijkl");

+ CHECK(!config->effective_experimental_options);

CHECK_EQ(config->storage_path,

base::android::ConvertJavaStringToUTF8(env, jstorage_path));

}