Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: components/cronet/url_request_context_config.h

Issue 2416473004: Add functionality for embedders to configure NQE (Closed)
Patch Set: ps Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/url_request_context_config.h
diff --git a/components/cronet/url_request_context_config.h b/components/cronet/url_request_context_config.h
index 7b13833b528f1485c3c576facd558a14d82b3c31..0a4cae32b192f4f45cf5b65ec0fd85577c9575cf 100644
--- a/components/cronet/url_request_context_config.h
+++ b/components/cronet/url_request_context_config.h
@@ -23,6 +23,7 @@ class SequencedTaskRunner;
namespace net {
class CertVerifier;
class NetLog;
+class NetworkQualityEstimatorParams;
class URLRequestContextBuilder;
} // namespace net
@@ -141,13 +142,6 @@ struct URLRequestContextConfig {
const std::string storage_path;
// User-Agent request header field.
const std::string user_agent;
- // Experimental options encoded as a string in a JSON format containing
- // experiments and their corresponding configuration options. The format
- // is a JSON object with the name of the experiment as the key, and the
- // configuration options as the value. An example:
- // {"experiment1": {"option1": "option_value1", "option2": "option_value2",
- // ...}, "experiment2: {"option3", "option_value3", ...}, ...}
- const std::string experimental_options;
// Certificate verifier for testing.
std::unique_ptr<net::CertVerifier> mock_cert_verifier;
@@ -171,6 +165,9 @@ struct URLRequestContextConfig {
std::unique_ptr<base::DictionaryValue> effective_experimental_options =
nullptr;
+ // Configuration parameters for the network quality estimator.
+ std::unique_ptr<net::NetworkQualityEstimatorParams> nqe_params;
+
private:
// Parses experimental options and makes appropriate changes to settings in
// the URLRequestContextConfig and URLRequestContextBuilder.
@@ -179,6 +176,14 @@ struct URLRequestContextConfig {
net::NetLog* net_log,
const scoped_refptr<base::SequencedTaskRunner>& file_task_runner);
+ // Experimental options encoded as a string in a JSON format containing
+ // experiments and their corresponding configuration options. The format
+ // is a JSON object with the name of the experiment as the key, and the
+ // configuration options as the value. An example:
+ // {"experiment1": {"option1": "option_value1", "option2": "option_value2",
+ // ...}, "experiment2: {"option3", "option_value3", ...}, ...}
+ const std::string experimental_options;
+
DISALLOW_COPY_AND_ASSIGN(URLRequestContextConfig);
};

Powered by Google App Engine
This is Rietveld 408576698