Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Issue 2416453007: Temporary disable of the new test because it is flaky. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/recent_tab_helper.h" 5 #include "chrome/browser/android/offline_pages/recent_tab_helper.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/test/scoped_feature_list.h" 10 #include "base/test/scoped_feature_list.h"
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 scoped_feature_list.Init(); 304 scoped_feature_list.Init();
305 NavigateAndCommit(kTestPageUrl); 305 NavigateAndCommit(kTestPageUrl);
306 recent_tab_helper()->DocumentOnLoadCompletedInMainFrame(); 306 recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
307 RunUntilIdle(); 307 RunUntilIdle();
308 EXPECT_TRUE(model()->is_loaded()); 308 EXPECT_TRUE(model()->is_loaded());
309 GetAllPages(); 309 GetAllPages();
310 // No page should be captured. 310 // No page should be captured.
311 EXPECT_EQ(0U, all_pages().size()); 311 EXPECT_EQ(0U, all_pages().size());
312 } 312 }
313 313
314 TEST_F(RecentTabHelperTest, DownloadRequest) { 314 TEST_F(RecentTabHelperTest, DISABLED_DownloadRequest) {
315 NavigateAndCommit(kTestPageUrl); 315 NavigateAndCommit(kTestPageUrl);
316 recent_tab_helper()->ObserveAndDownloadCurrentPage( 316 recent_tab_helper()->ObserveAndDownloadCurrentPage(
317 ClientId("download", "id1"), 153l); 317 ClientId("download", "id1"), 153l);
318 recent_tab_helper()->DocumentOnLoadCompletedInMainFrame(); 318 recent_tab_helper()->DocumentOnLoadCompletedInMainFrame();
319 RunUntilIdle(); 319 RunUntilIdle();
320 EXPECT_TRUE(model()->is_loaded()); 320 EXPECT_TRUE(model()->is_loaded());
321 GetAllPages(); 321 GetAllPages();
322 EXPECT_EQ(1U, all_pages().size()); 322 EXPECT_EQ(1U, all_pages().size());
323 const OfflinePageItem& page = all_pages()[0]; 323 const OfflinePageItem& page = all_pages()[0];
324 EXPECT_EQ(kTestPageUrl, page.url); 324 EXPECT_EQ(kTestPageUrl, page.url);
325 EXPECT_EQ("download", page.client_id.name_space); 325 EXPECT_EQ("download", page.client_id.name_space);
326 EXPECT_EQ("id1", page.client_id.id); 326 EXPECT_EQ("id1", page.client_id.id);
327 EXPECT_EQ(153l, page.offline_id); 327 EXPECT_EQ(153l, page.offline_id);
328 } 328 }
329 329
330 } // namespace offline_pages 330 } // namespace offline_pages
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698