Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2416453004:
Preserve color space of images in deferred texture API (Closed)
|
Created:
4 years, 2 months ago by Brian Osman Modified:
4 years, 2 months ago CC:
reviews_skia.org, ccameron, msarett Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionPreserve color space of images in deferred texture API
For raster images, this already worked (we were peeking the
pixmap's info). But for generated images, we discarded
format and color space information. Fixes an error with the
deferred GMs in sRGB modes, and also should help the Chrome
color correctness work.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416453004
Committed: https://skia.googlesource.com/skia/+/32b5e70178acda2ce1548cce1740841e7d30344a
Patch Set 1 #Patch Set 2 : Remove unused variable #Patch Set 3 : Rebase #Messages
Total messages: 21 (16 generated)
Description was changed from ========== Preserve color space of images in deferred texture API BUG=skia: ========== to ========== Preserve color space of images in deferred texture API BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416453004 ==========
The CQ bit was checked by brianosman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by brianosman@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Preserve color space of images in deferred texture API BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416453004 ========== to ========== Preserve color space of images in deferred texture API For raster images, this already worked (we were peeking the pixmap's info). But for generated images, we discarded format and color space information. Fixes an error with the deferred GMs in sRGB modes, and also should help the Chrome color correctness work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416453004 ==========
brianosman@google.com changed reviewers: + bsalomon@google.com, cblume@chromium.org, robertphillips@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
msarett@google.com changed reviewers: + msarett@google.com
lgtm
The CQ bit was checked by brianosman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on master.client.skia.android (JOB_FAILED, http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-N...)
The CQ bit was checked by brianosman@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Preserve color space of images in deferred texture API For raster images, this already worked (we were peeking the pixmap's info). But for generated images, we discarded format and color space information. Fixes an error with the deferred GMs in sRGB modes, and also should help the Chrome color correctness work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416453004 ========== to ========== Preserve color space of images in deferred texture API For raster images, this already worked (we were peeking the pixmap's info). But for generated images, we discarded format and color space information. Fixes an error with the deferred GMs in sRGB modes, and also should help the Chrome color correctness work. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2416453004 Committed: https://skia.googlesource.com/skia/+/32b5e70178acda2ce1548cce1740841e7d30344a ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/32b5e70178acda2ce1548cce1740841e7d30344a |
