Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2416433003:
Disable TestWebRequestListenerSurvivesReparenting for browser side navigation (Closed)
DescriptionDisable TestWebRequestListenerSurvivesReparenting for browser side navigation
WebViewTests_WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting is
highly flaky (currently 4/25 builds) in browser_side_navigation_browser_tests
on Linux.
As browser side navigation currently doesn't fully support WebView, it should
be just disabled.
TBR=jam@chromium.org,clamy@chromium.org
BUG=655145
Committed: https://crrev.com/6634a262d0c108f6149a3eb4bb09b5023bcc7402
Cr-Commit-Position: refs/heads/master@{#424867}
Patch Set 1 #
Messages
Total messages: 25 (14 generated)
The CQ bit was checked by msramek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Disable TestWebRequestListenerSurvivesReparenting for browser side navigation WebViewTests_WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting is highly flaky (currently 4/25 builds) in browser_side_navigation_browser_tests on Linux. As browser side navigation currently doesn't fully support WebView, it should be just disabled. BUG=655145 ========== to ========== Disable TestWebRequestListenerSurvivesReparenting for browser side navigation WebViewTests_WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting is highly flaky (currently 4/25 builds) in browser_side_navigation_browser_tests on Linux. As browser side navigation currently doesn't fully support WebView, it should be just disabled. TBR=jam@chromium.org,clamy@chromium.org BUG=655145 ==========
msramek@chromium.org changed reviewers: + clamy@chromium.org, jam@chromium.org
Disabling a flaky browser side navigation test; adding TBR jam@ as you added the other WebViewTest exceptions to the filter in the past.
The CQ bit was unchecked by msramek@chromium.org
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by msramek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Disable TestWebRequestListenerSurvivesReparenting for browser side navigation WebViewTests_WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting is highly flaky (currently 4/25 builds) in browser_side_navigation_browser_tests on Linux. As browser side navigation currently doesn't fully support WebView, it should be just disabled. TBR=jam@chromium.org,clamy@chromium.org BUG=655145 ========== to ========== Disable TestWebRequestListenerSurvivesReparenting for browser side navigation WebViewTests_WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting is highly flaky (currently 4/25 builds) in browser_side_navigation_browser_tests on Linux. As browser side navigation currently doesn't fully support WebView, it should be just disabled. TBR=jam@chromium.org,clamy@chromium.org BUG=655145 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable TestWebRequestListenerSurvivesReparenting for browser side navigation WebViewTests_WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting is highly flaky (currently 4/25 builds) in browser_side_navigation_browser_tests on Linux. As browser side navigation currently doesn't fully support WebView, it should be just disabled. TBR=jam@chromium.org,clamy@chromium.org BUG=655145 ========== to ========== Disable TestWebRequestListenerSurvivesReparenting for browser side navigation WebViewTests_WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting is highly flaky (currently 4/25 builds) in browser_side_navigation_browser_tests on Linux. As browser side navigation currently doesn't fully support WebView, it should be just disabled. TBR=jam@chromium.org,clamy@chromium.org BUG=655145 Committed: https://crrev.com/6634a262d0c108f6149a3eb4bb09b5023bcc7402 Cr-Commit-Position: refs/heads/master@{#424867} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6634a262d0c108f6149a3eb4bb09b5023bcc7402 Cr-Commit-Position: refs/heads/master@{#424867} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
