Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 241643006: Remove more dead code from core/ folder (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews, kenneth.christiansen, krit, kinuko+watch, fs, blink-layers+watch_chromium.org, falken, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, horo+watch_chromium.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Visibility:
Public.

Description

Remove more dead code from core/ folder Remove more dead code from core/ folder. Several functions were defined but never used. R=eseidel@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -145 lines) Patch
M Source/core/clipboard/DataObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/clipboard/DataObject.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/page/FocusController.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/page/FocusController.cpp View 2 chunks +0 lines, -40 lines 0 comments Download
M Source/core/page/PrintContext.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/page/PrintContext.cpp View 2 chunks +0 lines, -28 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/svg/SVGDocument.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGDocument.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/workers/WorkerThread.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 8 months ago (2014-04-18 14:04:53 UTC) #1
kenneth.r.christiansen
lgtm
6 years, 8 months ago (2014-04-18 17:45:42 UTC) #2
adamk
lgtm
6 years, 8 months ago (2014-04-18 18:01:54 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-18 18:02:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/241643006/1
6 years, 8 months ago (2014-04-18 18:02:51 UTC) #5
commit-bot: I haz the power
Change committed as 171960
6 years, 8 months ago (2014-04-18 18:14:33 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 18:14:58 UTC) #7
Message was sent while issue was closed.
Failed to apply patch for Source/core/clipboard/DataObject.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/clipboard/DataObject.cpp
  Hunk #1 FAILED at 124.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/clipboard/DataObject.cpp.rej

Patch:       Source/core/clipboard/DataObject.cpp
Index: Source/core/clipboard/DataObject.cpp
diff --git a/Source/core/clipboard/DataObject.cpp
b/Source/core/clipboard/DataObject.cpp
index
e904f89d9e290fbae463d49d80b37014efd1c28e..671af3d4e627cfc13ec626139551c90a8b6c8cd8
100644
--- a/Source/core/clipboard/DataObject.cpp
+++ b/Source/core/clipboard/DataObject.cpp
@@ -124,17 +124,6 @@ void DataObject::clearData(const String& type)
     }
 }
 
-void DataObject::clearAllExceptFiles()
-{
-    for (size_t i = 0; i < m_itemList.size(); ) {
-        if (m_itemList[i]->kind() != DataObjectItem::FileKind) {
-            m_itemList.remove(i);
-            continue;
-        }
-        ++i;
-    }
-}
-
 ListHashSet<String> DataObject::types() const
 {
     ListHashSet<String> results;

Powered by Google App Engine
This is Rietveld 408576698