third_party/WebKit/LayoutTests/dialog/scrollable-after-close.html - Issue 2416423003: Fix unscrollable scrollers after closing a <dialog>.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/dialog/scrollable-after-close.html

Issue 2416423003: Fix unscrollable scrollers after closing a <dialog>. (Closed)

Patch Set: address review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	esprehn 2016/10/17 20:30:09 leave out html, head and body leave out html, head and body
	4 <script src="../resources/js-test.js"></script>

	5 <style>

	6 html, body { height: 100%; margin: 0; overflow: hidden; }

	7 #scroller {

	8 overflow: scroll;

	9 position: relative;

	10 z-index: 0;

	11 width: 300px;

	12 height: 50%;

	13 left: 20px;

	14 top: 20px;

	15 border: 1px solid black;

	16 }

	17 </style>

	18 </head>

	19 <body>

	20 <dialog></dialog>

	21 <div id="scroller">

	22 <div style="height: 700px; width: 700px"></div>

	23 </div>

	24 <script>

	25

	26 description("Tests that FrameView::m_scrollableAreas is updated after " +

	27 "closing a modal dialog when the scroller and its ancestors " +

	28 "have percentage heights. (see crbug.com/633520)");

	29

	30 var dialog = document.querySelector("dialog");

	31 dialog.showModal();

	32 dialog.close();

	33

	34 // Force layout.

	35 document.body.offsetWidth;

	36

	37 shouldBe("internals.numberOfScrollableAreas(document)", "1");

	38

	39 </script>

	40 </body>

	41 </head>

	42 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/dialog/scrollable-after-close-expected.txt » ('j') | no next file with comments »