Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: ui/android/window_android.cc

Issue 2416403002: Reland of Android: support multiple displays on C++ side (Closed)
Patch Set: Ensure primary display. New jni scheme Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/window_android.cc
diff --git a/ui/android/window_android.cc b/ui/android/window_android.cc
index 7e40c8fb62e0ef658b1e094877498b12a4221c7b..9fd78ba1bfbb91407e28f034f20c7af4a5ea7a07 100644
--- a/ui/android/window_android.cc
+++ b/ui/android/window_android.cc
@@ -13,6 +13,7 @@
#include "jni/WindowAndroid_jni.h"
#include "ui/android/window_android_compositor.h"
#include "ui/android/window_android_observer.h"
+#include "ui/display/screen.h"
boliu 2016/10/27 22:17:49 this import seems unnecessary
Tima Vaisburd 2016/10/31 23:36:15 Removed.
namespace ui {
@@ -21,7 +22,8 @@ using base::android::JavaParamRef;
using base::android::JavaRef;
using base::android::ScopedJavaLocalRef;
-WindowAndroid::WindowAndroid(JNIEnv* env, jobject obj) : compositor_(NULL) {
+WindowAndroid::WindowAndroid(JNIEnv* env, jobject obj, int display_id)
+ : display_id_(display_id), compositor_(NULL) {
java_window_.Reset(env, obj);
}
@@ -46,8 +48,10 @@ WindowAndroid::~WindowAndroid() {
WindowAndroid* WindowAndroid::CreateForTesting() {
JNIEnv* env = AttachCurrentThread();
const JavaRef<jobject>& context = base::android::GetApplicationContext();
- return new WindowAndroid(
- env, Java_WindowAndroid_createForTesting(env, context).obj());
+ base::android::ScopedJavaLocalRef<jobject> java_window =
+ Java_WindowAndroid_createForTesting(env, context);
+ int display_id = Java_WindowAndroid_getDisplayId(env, java_window.obj());
+ return new WindowAndroid(env, java_window.obj(), display_id);
}
void WindowAndroid::DestroyForTesting() {
@@ -154,8 +158,8 @@ WindowAndroid* WindowAndroid::GetWindowAndroid() const {
// Native JNI methods
// ----------------------------------------------------------------------------
-jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj) {
- WindowAndroid* window = new WindowAndroid(env, obj);
+jlong Init(JNIEnv* env, const JavaParamRef<jobject>& obj, int sdk_display_id) {
+ WindowAndroid* window = new WindowAndroid(env, obj, sdk_display_id);
return reinterpret_cast<intptr_t>(window);
}

Powered by Google App Engine
This is Rietveld 408576698