ui/android/screen_android.h - Issue 2416403002: Reland of Android: support multiple displays on C++ side

Side by Side Diff: ui/android/screen_android.h

Issue 2416403002: Reland of Android: support multiple displays on C++ side (Closed)

Patch Set: Restore GetDisplayNearestWindow(0) functionality to return primary display. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java ('K') | « ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java ('k') | ui/android/ui_android_jni_registrar.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_ANDROID_SCREEN_ANDROID_H_

	6 #define UI_ANDROID_SCREEN_ANDROID_H_

	7

	8 #include <jni.h>

	9 #include "ui/android/ui_android_export.h"

	10

	11 namespace display {

	12 class Screen;

	13 }

	14

	15 namespace ui {

	16

	17 bool RegisterScreenAndroid(JNIEnv* env);

	18

	19 UI_ANDROID_EXPORT display::Screen* CreateScreenAndroid();
	boliu 2016/11/07 17:05:33 what if we also create the screen inside RegisterS what if we also create the screen inside RegisterScreenAndroid? a bit unidiomatic, but seems much easier? Tima Vaisburd 2016/11/07 18:26:04 I thought we wanted to be similar to other platfor Show quoted text On 2016/11/07 17:05:33, boliu wrote: > what if we also create the screen inside RegisterScreenAndroid? a bit > unidiomatic, but seems much easier? I thought we wanted to be similar to other platforms... I will try this idea. Tima Vaisburd 2016/11/09 01:17:01 Couldn't do it: in Chrome the call to Java_Display Show quoted text On 2016/11/07 18:26:04, Tima Vaisburd wrote: > On 2016/11/07 17:05:33, boliu wrote: > > what if we also create the screen inside RegisterScreenAndroid? a bit > > unidiomatic, but seems much easier? > > I thought we wanted to be similar to other platforms... I will try this idea. Couldn't do it: in Chrome the call to Java_DisplayAndroidManager_onNativeSideCreated() failed because it missed the command line object. In WebView, the JNI registration is skipped (btw, how does it work?), so RegisterScreenAndroid is not called at all. boliu 2016/11/09 03:34:25 meh, init is so complicated how about lazily when Show quoted text On 2016/11/09 01:17:01, Tima Vaisburd wrote: > On 2016/11/07 18:26:04, Tima Vaisburd wrote: > > On 2016/11/07 17:05:33, boliu wrote: > > > what if we also create the screen inside RegisterScreenAndroid? a bit > > > unidiomatic, but seems much easier? > > > > I thought we wanted to be similar to other platforms... I will try this idea. > > Couldn't do it: in Chrome the call to > Java_DisplayAndroidManager_onNativeSideCreated() failed because it missed the > command line object. meh, init is so complicated how about lazily when the primary display is registered? as you can see, if you want to add an explicit init call, then you need to add that call in a lot of places.. Show quoted text > In WebView, the JNI registration is skipped (btw, how does > it work?), so RegisterScreenAndroid is not called at all. Oh yeah.. forgot, jni registration is lazy in webview Tima Vaisburd 2016/11/09 09:01:43 Sigh.. maybe in some common part in the content la Show quoted text On 2016/11/09 03:34:25, boliu wrote: > On 2016/11/09 01:17:01, Tima Vaisburd wrote: > > On 2016/11/07 18:26:04, Tima Vaisburd wrote: > > > On 2016/11/07 17:05:33, boliu wrote: > > > > what if we also create the screen inside RegisterScreenAndroid? a bit > > > > unidiomatic, but seems much easier? > > > > > > I thought we wanted to be similar to other platforms... I will try this > idea. > > > > Couldn't do it: in Chrome the call to > > Java_DisplayAndroidManager_onNativeSideCreated() failed because it missed the > > command line object. > > meh, init is so complicated > > how about lazily when the primary display is registered? > > as you can see, if you want to add an explicit init call, then you need to add > that call in a lot of places.. > > > In WebView, the JNI registration is skipped (btw, how does > > it work?), so RegisterScreenAndroid is not called at all. > > Oh yeah.. forgot, jni registration is lazy in webview Sigh.. maybe in some common part in the content layer initialization?
	20

	21 } // namespace display

	22

	23 #endif // UI_ANDROID_SCREEN_ANDROID_H_

OLD	NEW