Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2416393002: Revert of [wasm] Fix bounds check for zero initial memory. (Closed)

Created:
4 years, 2 months ago by gdeepti
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Fix bounds check for zero initial memory. (patchset #11 id:200001 of https://codereview.chromium.org/2416543002/ ) Reason for revert: Reverting because of failure on V8 Linux64 GC Stress http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/8572 Original issue's description: > [wasm] Fix bounds check for zero initial memory. > > Currently when memory size references are updated with zero initial memory during GrowMemory/Relocation of Instance objects, the bounds check does not take into account the size of memtype. > > R=titzer@chromium.org, bradnelson@chromium.org > > Committed: https://crrev.com/70416a2b360c0d993cffb48284b143d484d1e290 > Cr-Commit-Position: refs/heads/master@{#40326} TBR=bradnelson@chromium.org,titzer@chromium.org,bradnelson@google.com,mtrofin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2c4563003cdaa7342cd26a279d9fa89268922741 Cr-Commit-Position: refs/heads/master@{#40328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -131 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 3 chunks +39 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/grow-memory.js View 2 chunks +5 lines, -88 lines 0 comments Download
M test/mjsunit/wasm/import-memory.js View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
gdeepti
Created Revert of [wasm] Fix bounds check for zero initial memory.
4 years, 2 months ago (2016-10-14 22:32:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416393002/1
4 years, 2 months ago (2016-10-14 22:32:32 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-14 22:32:34 UTC) #5
gdeepti
4 years, 2 months ago (2016-10-14 22:32:50 UTC) #6
alph
lgtm
4 years, 2 months ago (2016-10-14 22:42:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2416393002/1
4 years, 2 months ago (2016-10-14 22:42:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 22:42:56 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 22:43:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c4563003cdaa7342cd26a279d9fa89268922741
Cr-Commit-Position: refs/heads/master@{#40328}

Powered by Google App Engine
This is Rietveld 408576698